Skip to content

Commit

Permalink
[Fix] Marked address as optional field to support next_available_ip (#15
Browse files Browse the repository at this point in the history
)

* marked address as optional field to support next_available_ip

* addressed review comments
  • Loading branch information
VishrutiBuddhadev authored Jan 10, 2025
1 parent 8ac9f0c commit 4756efb
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
2 changes: 1 addition & 1 deletion src/ipam/docs/Address.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ An __Address__ object (_ipam/address_) represents any single IP address within a

Name | Type | Description | Notes
------------ | ------------- | ------------- | -------------
**address** | **str** | The address in form \"a.b.c.d\". |
**address** | **str** | The address in form \"a.b.c.d\". | [optional]
**comment** | **str** | The description for the address object. May contain 0 to 1024 characters. Can include UTF-8. | [optional]
**compartment_id** | **str** | The compartment associated with the object. If no compartment is associated with the object, the value defaults to empty. | [optional] [readonly]
**created_at** | **datetime** | Time when the object has been created. | [optional] [readonly]
Expand Down
3 changes: 2 additions & 1 deletion src/ipam/models/address.py
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,8 @@ class Address(BaseModel):
"""
An __Address__ object (_ipam/address_) represents any single IP address within a given IP space.
""" # noqa: E501
address: StrictStr = Field(description="The address in form \"a.b.c.d\".")
address: Optional[StrictStr] = Field(
default=None, description="The address in form \"a.b.c.d\".")
comment: Optional[StrictStr] = Field(
default=None,
description=
Expand Down

0 comments on commit 4756efb

Please sign in to comment.