Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: to timezone specific datetime helper to avoid use deprecated functions #652

Merged
merged 3 commits into from
Jun 26, 2024

Conversation

bednar
Copy link
Contributor

@bednar bednar commented May 2, 2024

Closes #603

Proposed Changes

image
image

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • pytest tests completes successfully
  • Commit messages are conventional
  • Sign CLA (if not already signed)

@bednar bednar marked this pull request as ready for review May 2, 2024 07:49
@bednar bednar requested a review from karel-rehor May 2, 2024 07:49
@codecov-commenter
Copy link

codecov-commenter commented May 2, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.43%. Comparing base (b844a82) to head (e205347).
Report is 10 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #652   +/-   ##
=======================================
  Coverage   90.43%   90.43%           
=======================================
  Files          40       40           
  Lines        3524     3524           
=======================================
  Hits         3187     3187           
  Misses        337      337           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bednar bednar force-pushed the datetime-deprecation branch from 1b7d42a to 90a5edc Compare June 26, 2024 08:48
Copy link
Contributor

@karel-rehor karel-rehor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests and changed examples pass locally. Changes look correct. OK.

@bednar bednar merged commit 653af46 into master Jun 26, 2024
15 checks passed
@bednar bednar deleted the datetime-deprecation branch June 26, 2024 13:00
@bednar bednar added this to the 1.45.0 milestone Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace deprecated call to datetime.utcfromtimestamp
3 participants