Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lower-to-higher precision conversion in _convert_timestamp #650

Conversation

rwader-swi
Copy link

Closes #

Proposed Changes

Currently the _convert_timestamp util only supports higher precision to lower precision time conversion. Some of the usecases might need the opposite, and instead of writing on our own we wish to use this already present utility. In my usecase the data is in floating point as seconds which I might want to convert to nanoseconds or other precision. So did some small changes.

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • pytest tests completes successfully
  • Commit messages are conventional
  • Sign CLA (if not already signed)

@bednar
Copy link
Contributor

bednar commented Aug 12, 2024

This PR has been closed because it has not had recent activity. Please reopen if this PR is still important to you and you want to continue with them.

@bednar bednar closed this Aug 12, 2024
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.42%. Comparing base (a645ea9) to head (0a8ea0b).
Report is 26 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #650   +/-   ##
=======================================
  Coverage   90.42%   90.42%           
=======================================
  Files          39       39           
  Lines        3509     3509           
=======================================
  Hits         3173     3173           
  Misses        336      336           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants