Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: code format #61

Merged
merged 10 commits into from
Jan 22, 2025
Merged

chore: code format #61

merged 10 commits into from
Jan 22, 2025

Conversation

luohoufu
Copy link
Contributor

What does this PR do

code format

Rationale for this change

This pull request includes significant updates to the CI/CD workflows and some cleanup of unused code. The most important changes include creating a new PR check workflow, removing the old unit test workflow, and deleting unused generated configuration constants.

CI/CD Workflow updates:

  • .github/workflows/pr-check.yml: Added a new workflow for PR checks that includes steps for format checking, unit testing, and code linting. This workflow ensures code quality by verifying formatting, running unit tests, and performing lint checks.
  • .github/workflows/unit_test.yml: Removed the old unit test workflow as it has been integrated into the new PR check workflow.

Code cleanup:

Standards checklist

  • The PR title is descriptive
  • The commit messages are semantic
  • Necessary tests are added
  • Updated the release notes
  • Necessary documents have been added if this is a new feature
  • Performance tests checked, no obvious performance degradation

@luohoufu luohoufu requested review from medcl and silenceqi January 14, 2025 10:17
@medcl
Copy link
Member

medcl commented Jan 22, 2025

fix this build first maybe

@luohoufu luohoufu merged commit 9fc81e3 into main Jan 22, 2025
5 of 6 checks passed
@luohoufu luohoufu deleted the format_pr branch January 22, 2025 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants