Fix Inertia Head rendering error when tags contain dynamic value #1997
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When putting dynamic value or javascript in a tag's content inside Inertia's Head component, it compiles to a jsx element containing an any[] children.
renderTag
function from Head will recursively render every children, and in this case, trying to access a string node.props will throw an uncatched exception and will break rendering:Taking as example the React playground from Inertia repository,
Would break rendering and just return the template html to the client:
Note that nor the tags inside of Head have been rendered.
Making the following change at Head components (in Vue and React packages) avoid trying to access
node.props
from the node if it is a string and fixes the issue: