Update SpatialiteReactPackage.java #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
navarroaxel
suggested changes
Oct 8, 2018
android/src/main/java/ar/gov/indec/react/spatialite/SpatialiteReactPackage.java
Show resolved
Hide resolved
android/src/main/java/ar/gov/indec/react/spatialite/SpatialiteReactPackage.java
Show resolved
Hide resolved
android/src/main/java/ar/gov/indec/react/spatialite/SpatialiteReactPackage.java
Show resolved
Hide resolved
navarroaxel
suggested changes
Oct 8, 2018
| @@ -11,19 +11,19 @@ | |||
| import java.util.Collections; | |||
|
|
|||
| public class SpatialiteReactPackage implements ReactPackage { | |||
| @Override | |||
|
|
|||
| public List<NativeModule> createNativeModules(ReactApplicationContext reactContext) { | |||
There was a problem hiding this comment.
But the official doc says that createViewManagers and createNativeModules should be decorated with @Override here https://facebook.github.io/react-native/docs/native-modules-android.
Maybe this was a breaking change because createJSModules is not longer in the docs. We should check and upgrade the react-native package on the peerDependencies@ package.json to be clear of the breaking change.
There was a problem hiding this comment.
[email protected] removed createJSModules on Android.
We can delete the createJSModules completly and we should keep the @Override decorator on the other 2 methods.
And we should upgrade the peerDependencies for react-native@>=0.47.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3