Feat/API-Product #18
Merged
Feat/API-Product #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
1 task
brandonw504
requested changes
Mar 10, 2024
There was a problem hiding this comment.
Just a few things:
- Rename Product.ts to Products.ts in services, since we want to keep them plural
- Run the migration (should show up in your commit in the migrations folder)
- Remember to test your CRUD operations in the playground
- Maybe make description and details nullable (@Austin2Shih thoughts?)
|
Tested ✅ |
|
@brandonw504 final review and merge if good :) |
brandonw504
approved these changes
Apr 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Create Product model and CRUD operations
Issue
Closes #7