-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: newgrounds support #639
Conversation
https://www.newgrounds.com/audio/listen/1343831 doesn't work
|
everything seems to be good, if anyone wants to take a look |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
deepsource fixes
Was not aware about rebasing, I'll fix that for the future. To fix the ugly messages, I can redo this PR if needed. |
i don't think you need to redo the pr, i didn't see any prs be rejected because of that |
ok that did not work, thanks github for the merge 👍 |
but why |
going to redo this, the branch is out of date and I don't want all the ugly testing commits in it |
A WIP pull request for adding Newgrounds support, from #620.
Would love some help with this, never worked with cobalt source before or Javascript.
Links supported:
Here is what's missing:
undefined
.newgrounds_id.undefined
)