feat(cli): watch paths for auto uploading daemon #14923
Open
+409
−44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eligao
force-pushed
the
feat/cli-watch-changes
branch
from
78824da to
32ba427
Compare
jrasm91
reviewed
Dec 28, 2024
Comment on lines
+74
to
+78
| options: UploadOptionsDto, | ||
| { | ||
| batchSize = UPLOAD_WATCH_BATCH_SIZE, | ||
| debounceTimeMs = UPLOAD_WATCH_DEBOUNCE_TIME_MS, | ||
| }: { batchSize?: number; debounceTimeMs?: number } = {}, |
There was a problem hiding this comment.
I think you should only pass a single options object here
There was a problem hiding this comment.
I considered doing this, but it would be error prone to mix/unmix watch-specific params with the UploadOptionsDto which would be later passed into uploadBatch()
| const extensions = new Set([...image, ...video]); | ||
|
|
||
| if (options.ignore) { | ||
| watcherIgnored.push((path) => micromatch.contains(path, `**/${options.ignore}`)); |
There was a problem hiding this comment.
What if the ignored path contains special characters?, like curly brace, comma, $, etc?
There was a problem hiding this comment.
it will be handled in the same way as crawl(), which internally calls fast-glob and then also micromatch:
https://github.com/eligao/immich/blob/fe71f7303ddc0950f7f8464853dac27fdf99fe38/cli/src/utils.ts#L160
eligao
force-pushed
the
feat/cli-watch-changes
branch
from
c267202 to
3e74c98
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
--watchflag to continue watching for changes after initial upload.immich upload ./assets/ --watch--watch, as it batch uploads all current items in one go.--no-progressflag to hide progress bars to make logs cleaner when running as a daemon--watchflag