This repository has been archived by the owner on Sep 26, 2023. It is now read-only.
Starter guide for Android SDK #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AniVerma17
commented
Sep 8, 2023
AniVerma17
commented
- Add the quick start guide to document the steps of installing and using the ImageKit Android SDK.
- Update the summary file to add the link of the Android SDK guide.
AniVerma17
force-pushed
the
chore/android_quickstart_guide
branch
from
10485af to
e3be061
Compare
ahnv
suggested changes
Sep 22, 2023
|
|
||
| #### Installing the SDK | ||
|
|
||
| To Install the SDK, add the following to the root-level `build.gradle`: |
There was a problem hiding this comment.
Suggested change
| To Install the SDK, add the following to the root-level `build.gradle`: | |
| To install the SDK, add the following to the root-level `build.gradle`: |
|
|
||
| ## **Clone and run the tutorial app** | ||
|
|
||
| For this tutorial, it is recommended to use the sample Android app, as shown below. If you already have an existing Android app, it is also possible to use that, which will be explained in the continuation of the sample app. |
There was a problem hiding this comment.
This statement seems ambiguous. It is a bit unclear. The first part talks about a recommended sample app, but the second part about an existing app and its continuation might confuse readers.
Suggested change
| For this tutorial, it is recommended to use the sample Android app, as shown below. If you already have an existing Android app, it is also possible to use that, which will be explained in the continuation of the sample app. | |
| For this tutorial, we'll primarily use a sample Android app provided below. If you have your own existing Android app, you can integrate ImageKit into it. Instructions for both scenarios are provided in the subsequent sections. |
There was a problem hiding this comment.
Modified this paragraph to clear the ambiguity. Please check
| // https://ik.imagekit.io/your_imagekit_id/medium_cafe_B1iTdD0C.jpg?tr=oi-logo-white_SJwqB4Nfe.png,ox-10,oy-20 | ||
| ImageKit.getInstance() | ||
| .url( | ||
| src = https://ik.imagekit.io/your_imagekit_id/medium_cafe_B1iTdD0C.jpg", |
There was a problem hiding this comment.
Suggested change
| src = https://ik.imagekit.io/your_imagekit_id/medium_cafe_B1iTdD0C.jpg", | |
| src = "https://ik.imagekit.io/your_imagekit_id/medium_cafe_B1iTdD0C.jpg", |
Comment on lines
244
to
245
| publicKey: "your_public_api_key", | ||
| urlEndpoint: "your_url_endpoint", |
There was a problem hiding this comment.
Add comments to inform the user to replace these values
AniVerma17
force-pushed
the
chore/android_quickstart_guide
branch
from
b043074 to
33b807b
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.