Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verifier ID authentication in the Universal Verifier contract #323

Merged
merged 2 commits into from
Dec 17, 2024
Merged

Verifier ID authentication in the Universal Verifier contract #323

merged 2 commits into from
Dec 17, 2024

Conversation

AndriianChestnykh
Copy link
Collaborator

No description provided.

@AndriianChestnykh AndriianChestnykh changed the title Initial verifier authentication Verifier ID authentication in the Universal Verifier contract Dec 12, 2024
@coveralls
Copy link

coveralls commented Dec 12, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 12377401586

Details

  • 4 of 5 (80.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.01%) to 81.568%
Changes Missing Coverage Covered Lines Changed/Added Lines %
contracts/validators/EthIdentityValidator.sol 0 1 0.0%
Totals Coverage Status
Change from base Build 12303229864: -0.01%
Covered Lines: 1177
Relevant Lines: 1344
💛 - Coveralls

daveroga
daveroga approved these changes Dec 12, 2024
View reviewed changes
Copy link
Contributor

@daveroga daveroga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good approach to check verifier authentication!

@daveroga daveroga marked this pull request as ready for review December 17, 2024 16:39
@daveroga daveroga merged commit 14ca44b into PID-2709-full-multi-query-support-on-chain Dec 17, 2024
5 checks passed
@daveroga daveroga deleted the feature/PID-2714-optional-verifers-auth branch December 17, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daveroga daveroga daveroga approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AndriianChestnykh @coveralls @daveroga