make flag to optionally print/suppress aux variable creation printing #29665
Conversation
|
Job Documentation, step Docs: sync website on 960e9a4 wanted to post the following: View the site here This comment will be updated on new commits. |
|
Job Coverage, step Generate coverage on 960e9a4 wanted to post the following: Framework coverage
Modules coverageCoverage did not change Full coverage reportsReports
This comment will be updated on new commits. |
||||||||||||||||||||||||||
| const Action * common = common_actions.empty() ? nullptr : *common_actions.begin(); | ||
| if (common && !common->getParam<bool>("print_automatic_aux_variable_creation")) | ||
| print_aux_creation = false; | ||
| if (material_names.size() > 0 && print_aux_creation) |
There was a problem hiding this comment.
so you are really adding this to silence it?
There was a problem hiding this comment.
Yeah. Maybe there's a better way, but I wanted to protect against common not being found (or at least copy and pasted it from the way it's done elsewhere). In otherwords, if common is not found, allow it to print as normal.
There was a problem hiding this comment.
I mean the PR in general not just these few lines
There was a problem hiding this comment.
Oh ha! Yes, I'll change it...
tophmatthews
changed the title
|
I ll add a commit soon as I was tying something out. I think CommonOuptutAction isnt the best fit here, but with some changes MaterialOutputAction can host the capability / option on its own. |
material output action refs idaholab#29664
GiudGiud
force-pushed
the
mat_aux_output_29664
branch
from
ff0159a to
45ea0f2
Compare
|
@lindsayad for the independent review please |
|
slick! Thanks! |
|
|
|
I m not sure. Do they happen elsewhere? They seem tied to material properties output in an exodus file |
|
Yeah, they don't happen in another PR |
|
|
|
I'm building griffin to take a look |
|
@GiudGiud Did you figure out the griffin problem? The doco problem is simple. I can fix it, but didn't want to get tangled with your updates. |
|
No not yet. It's got to do with how they inherit the action in one of their own actions but no luck yet |
GiudGiud
force-pushed
the
mat_aux_output_29664
branch
from
fe27f13 to
960e9a4
Compare
|
doco should be good (though I ll watch it) |
|
Thanks for the review Alex! I'll re-request if we make any significant change but I dont think we will need to |
Closes #29664