Add a Physics for linear FV + mixture model #29614
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phase rather than relying on the problem solve calls
- more compact syntax - remove extra header - remove any form of solve from DumpObjectsProblem but dont both printing again Co-authored-by: Alex Lindsay <[email protected]>
…tween linear and nonlinear implementations
Currently a steady solve with only velocity-pressure, not converging. Try transient WIP
GiudGiud
force-pushed
the
PR_linear_twophase
branch
from
213f26e to
b438a24
Compare
|
Job Precheck, step Clang format on 8248e8f wanted to post the following: Your code requires style changes. A patch was auto generated and copied here
Alternatively, with your repository up to date and in the top level of your repository:
|
GiudGiud
force-pushed
the
PR_linear_twophase
branch
from
8248e8f to
c7c56d2
Compare
|
Job Documentation, step Docs: sync website on c7c56d2 wanted to post the following: View the site here This comment will be updated on new commits. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires #29177 and maybe #29516 to try out transients (or some other way to get a converged solution)
One difficulty is likely that the two phase equation needs to be an "active" scalar, not a passive one, and be solved inside the pressure-velocity-energy picard iteration.
I added code for that. I ll revisit this PR once the prereqs are merged