[WIP] Use hash table matrices when requested #28979
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We actually had a bug where we were attempting to close the RHS vector which is locked by PETSc. Indeed the RHS vector in libMesh and the vector which PETSc sends us for filling the residual are not the same vector
But do clear them at the end of the methods that set them. This ensures that overrides of `computeResidualTags` can safely assume that the incoming tags are indeed `const` and not changing out from under them in the case that they call down to `FEProblemBase::computeResidualTags`
Refs #0
Previously this test was relying on the residual going to true 0 which is unreasonable to expect generally speaking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for problems for which the sparsity pattern is difficult to compute or changing from nonlinear iteration to nonlinear iteration or from timestep to timestep. Refs petsc/petsc#7939 and libMesh/libmesh#3983