-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update parameter descriptions to use new API #397
Open
HiddenRoom
wants to merge
28
commits into
idaholab:devel
Choose a base branch
from
HiddenRoom:units
base: devel
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
0bfce67
WIP - param.setDocUnit(...) for units for relevant params
9a630e7
Merge branch 'idaholab:devel' into units
HiddenRoom 6ede39d
WIP - param.setDocUnit(...) for units for relevant params ref #396
168b001
autogenerated style changes
7fc5b8d
requested changes
e9a1316
clarify ambiguity in temperatures and add energy units
6c53cdf
add strength and stress units
eea17f3
updated strain to be unitless
194b8e1
typo
HiddenRoom 48c1392
Updating stable moose submodule refs #000
048f33f
Updating stable moose submodule refs #000
8020fc4
Updating stable moose submodule refs #000
0479c15
Updating stable moose submodule refs #000
db7bb31
Updating stable moose submodule refs #000
b5df938
Update NEML submodule ref #66
bwspenc aa528b4
Updating stable moose submodule refs #000
4607275
Updating stable moose submodule refs #000
75fe0cb
Updating stable moose submodule refs #000
faf07cb
Bump some tolerances in concrete tests
lindsayad ec3ebbb
Updating stable moose submodule refs #000
fdc35f0
Additional units and clarifaction
175d5b9
Update src/materials/ConcreteThermalMoisture.C
HiddenRoom 3b392f4
Update src/materials/ConcreteThermalMoisture.C
HiddenRoom 4fdc4b1
Update src/materials/ConcreteThermalMoisture.C
HiddenRoom 500568d
Update src/materials/ConcreteThermalMoisture.C
HiddenRoom a59aeb0
remove comment
9075c74
Celcius units
679ae58
cure time units
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Submodule neml
updated
16 files
+1 −1 | .github/workflows/package.yml | |
+1 −1 | .github/workflows/test_packages.yml | |
+1 −0 | include/damage.h | |
+1 −0 | include/neml_interface.h | |
+2 −0 | include/nemlerror.h | |
+3 −0 | neml/__init__.py | |
+17 −7 | neml/drivers.py | |
+1 −1 | pybind11 | |
+16 −6 | src/cp/batch.cxx | |
+18 −16 | src/damage.cxx | |
+0 −1 | src/nemlerror.cxx | |
+5 −0 | src/nemlerror_wrap.cxx | |
+2 −2 | test/test_nemlmath.py | |
+1 −1 | test/test_parse.py | |
+1 −1 | util/neml2_verification/README.md | |
+1 −1 | util/neml2_verification/run_neml2_test.py |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -7,23 +7,23 @@ | |
[shrinkage] | ||
type = 'Exodiff' | ||
input = 'shrinkage.i' | ||
# abs_zero = 1e-5 | ||
abs_zero = 2e-5 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This file shouldn't be changed. There was another commit that got merged in that modified these. |
||
exodiff = 'shrinkage_out.e' | ||
detail = 'with an exponent of 1, ' | ||
[] | ||
[shrinkage_quad] | ||
type = 'Exodiff' | ||
input = 'shrinkage.i' | ||
cli_args = 'Materials/shrinkage/exponent=2 Outputs/file_base=shrinkage_quad_out' | ||
abs_zero = 1e-5 | ||
abs_zero = 2e-5 | ||
exodiff = 'shrinkage_quad_out.e' | ||
detail = 'with an exponent of 2, ' | ||
[] | ||
[shrinkage_irreversible] | ||
type = 'Exodiff' | ||
input = 'shrinkage.i' | ||
cli_args = 'Materials/shrinkage/irreversibility_threshold=0.2 Outputs/file_base=shrinkage_irreversible_out' | ||
abs_zero = 1e-5 | ||
abs_zero = 2e-5 | ||
exodiff = 'shrinkage_irreversible_out.e' | ||
detail = 'and with an irreversibility threshold of 0.2.' | ||
[] | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -68,7 +68,7 @@ | |
type = 'CSVDiff' | ||
input = 'concrete_expansion_microcracking.i' | ||
csvdiff = 'concrete_expansion_microcracking_5_5_out.csv' | ||
abs_zero = 1e-6 | ||
abs_zero = 2e-6 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This file shouldn't be changed either. |
||
cli_args = 'Materials/microcracking/expansion_stress_limit=10e6 BCs/load_x/value=-5e6 BCs/load_y/value=-5e6 ' | ||
'Outputs/file_base=concrete_expansion_microcracking_5_5_out' | ||
allow_test_objects = True | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in unit specified by 'temperature_units'