Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified unit tests to use Unittest tester #38

Merged
merged 4 commits into from
Dec 16, 2024

Conversation

caleb-sitton-inl
Copy link
Collaborator

@caleb-sitton-inl caleb-sitton-inl commented Dec 13, 2024


Pull Request Description

What issue does this change request address? (Use "#" before the issue to link it, i.e., #42.)
What are the significant changes in functionality due to this change request?

This updates the unit tests in FORCE to use the new Unittest tester that was added in RAVEN.


For Change Control Board: Change Request Review

The following review must be completed by an authorized member of the Change Control Board.

  • 1. Review all computer code.
  • 2. Make sure the Python code and commenting standards are respected (camelBack, etc.) - See on the wiki for details.
  • 3. Automated Tests should pass, including run_tests, pylint, and manual building tests.
  • 4. If significant functionality is added, there must be tests added to check this. Tests should cover all possible options. Multiple short tests are preferred over one large test.
  • 5. If the change modifies or adds a requirement or a requirement based test case, the Change Control Board's Chair or designee also needs to approve the change. The requirements and the requirements test shall be in sync.
  • 6. The merge request must reference an issue. If the issue is closed, the issue close checklist shall be done.

@caleb-sitton-inl caleb-sitton-inl added the Do Not Merge This is not ready to be merged label Dec 13, 2024
@caleb-sitton-inl
Copy link
Collaborator Author

The unit tests are not being run, probably because the submodule of RAVEN does not include the Unittest tester. I believe this should be solved when the next version of RAVEN is released and includes the Unittest tester.

Copy link
Collaborator

@dylanjm dylanjm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes are good to merge.

@dylanjm
Copy link
Collaborator

dylanjm commented Dec 16, 2024

@caleb-sitton-inl I think we can update the RAVEN submodule here in FORCE to get the changes into our repo.

@dylanjm dylanjm merged commit a9c9275 into idaholab:main Dec 16, 2024
1 check passed
@caleb-sitton-inl caleb-sitton-inl deleted the use-unittest-tester branch December 23, 2024 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Do Not Merge This is not ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants