-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create easily installable packages of FORCE tools #37
Conversation
So instead we can manually run print_loc.py to get the file, and then copy and past that into setup.py instead of using the import.
…statements to GUI text
* Adds a basic GUI to run HERON and RAVEN * Makes minor changes to package requirements for installation
* Handles ipopt files for building executable * Fixes issue for netCDF4 import on Windows
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have reviewed this and overall, it looks reasonable. I left a few comments. (I contributed to this pull so I can't approve by myself.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ran thru the README instructions on windows, and it generally worked. Thank you. I left some comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes. No new comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a small update to documentation then should be ready to merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes are good to merge. Thanks!
Pull Request Description
What issue does this change request address? (Use "#" before the issue to link it, i.e., #42.)
#36
What are the significant changes in functionality due to this change request?
For Change Control Board: Change Request Review
The following review must be completed by an authorized member of the Change Control Board.