Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic charging models #9

Merged
merged 47 commits into from
Jul 17, 2024
Merged

Dynamic charging models #9

merged 47 commits into from
Jul 17, 2024

Conversation

manoj1511
Copy link
Collaborator

@manoj1511 manoj1511 commented May 22, 2023

Summary/Motivation

The charging models were static. Switching between different charging models in different projects needed a full cmake reconfiguration and compilation. This pull request addresses this issue by making the charging models dynamically loaded from input files.

Link to Issue

closes #13

Checklist before requesting a review

  • I have reviewed changed locally
  • I have updated tests if relevant
  • I have updated documentation if relevant

@steven-schmidt-inl steven-schmidt-inl force-pushed the ICM_upgrade branch 2 times, most recently from 787b705 to 3a71561 Compare June 8, 2023 21:27
@manoj1511 manoj1511 changed the title WIP: ICM upgrade Dynamic charging models Jul 25, 2023
steven-schmidt-inl and others added 4 commits August 15, 2023 09:23
@manoj1511 manoj1511 merged commit 07ac52c into develop Jul 17, 2024
@manoj1511 manoj1511 deleted the ICM_upgrade branch July 17, 2024 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants