PEL for vpd_specific_utility file #563
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RekhaAparna01
requested review from
jinuthomas,
PriyangaRamasamy,
souvik1914581,
SunnySrivastava1984 and
branupama
RekhaAparna01
force-pushed
the
pelForVpdSpecificUtility
branch
2 times, most recently
from
c561c04 to
6f3547f
Compare
| logging::logMessage( | ||
| EventLogger::createSyncPel( | ||
| types::ErrorType::InvalidVpdMessage, | ||
| types::SeverityType::Informational, __FILE__, __FUNCTION__, 0, | ||
| "Inserting properties into interface[" + interface + |
There was a problem hiding this comment.
nit: space missing between "interface" and "["
RekhaAparna01
force-pushed
the
pelForVpdSpecificUtility
branch
from
6f3547f to
0c3f919
Compare
souvik1914581
approved these changes
Jan 16, 2025
branupama
suggested changes
Jan 16, 2025
| EventLogger::createSyncPel( | ||
| types::ErrorType::InvalidVpdMessage, | ||
| types::SeverityType::Informational, __FILE__, __FUNCTION__, 0, | ||
| "Failed to expand location code with exception: " + |
There was a problem hiding this comment.
should we add "unexpandedLocationCode" in the description ?
There was a problem hiding this comment.
Yes, it should be added, else there is no way it can be identified what failed, just by looking at the PEL,
SunnySrivastava1984
requested changes
Jan 17, 2025
| EventLogger::createSyncPel( | ||
| types::ErrorType::InvalidVpdMessage, | ||
| types::SeverityType::Informational, __FILE__, __FUNCTION__, 0, | ||
| "Failed to expand location code with exception: " + |
There was a problem hiding this comment.
Yes, it should be added, else there is no way it can be identified what failed, just by looking at the PEL,
This commit adds code to log PEL in vpd_specific_utility file, in case
of exceptions occurred while reset data under PIM and get expanded
location code.
output:
'''
root@p10bmc:~# peltool -i 0x500024E0
{
"Private Header": {
"Section Version": "1",
"Sub-section type": "0",
"Created by": "bmc vpd",
"Created at": "01/15/2025 08:03:41",
"Committed at": "01/15/2025 08:03:41",
"Creator Subsystem": "BMC",
"CSSVER": "",
"Platform Log Id": "0x500024E0",
"Entry Id": "0x500024E0",
"BMC Event Log Id": "753"
},
"User Header": {
"Section Version": "1",
"Sub-section type": "0",
"Log Committed by": "bmc error logging",
"Subsystem": "CEC Hardware - VPD Interface",
"Event Scope": "Entire Platform",
"Event Severity": "Informational Event",
"Event Type": "Miscellaneous, Informational Only",
"Action Flags": [
"Event not customer viewable",
"Report Externally"
],
"Host Transmission": "Not Sent",
"HMC Transmission": "Not Sent"
},
"Primary SRC": {
"Section Version": "1",
"Sub-section type": "1",
"Created by": "bmc vpd",
"SRC Version": "0x02",
"SRC Format": "0x55",
"Virtual Progress SRC": "False",
"I5/OS Service Event Bit": "False",
"Hypervisor Dump Initiated":"False",
"Backplane CCIN": "2E2D",
"Terminate FW Error": "False",
"Deconfigured": "False",
"Guarded": "False",
"Error Details": {
"Message": "A VPD data exception occurred."
},
"Valid Word Count": "0x09",
"Reference Code": "BD554001",
"Hex Word 2": "00000055",
"Hex Word 3": "2E2D0010",
"Hex Word 4": "00000000",
"Hex Word 5": "00000000",
"Hex Word 6": "00000000",
"Hex Word 7": "00000000",
"Hex Word 8": "00000000",
"Hex Word 9": "00000000"
},
"Extended User Header": {
"Section Version": "1",
"Sub-section type": "0",
"Created by": "bmc error logging",
"Reporting Machine Type": " ",
"Reporting Serial Number": " ",
"FW Released Ver": "RB1110_025",
"FW SubSys Version": "fw1110.00-3.53",
"Common Ref Time": "00/00/0000 00:00:00",
"Symptom Id Len": "20",
"Symptom Id": "BD554001_2E2D0010"
},
"Failing MTMS": {
"Section Version": "1",
"Sub-section type": "0",
"Created by": "bmc error logging",
"Machine Type Model": " ",
"Serial Number": " "
},
"User Data 0": {
"Section Version": "1",
"Sub-section type": "1",
"Created by": "bmc error logging",
"BMCLoad": "0.82 0.82 0.68",
"BMCState": "Ready",
"BMCUptime": "0y 0d 0h 17m 41s",
"BootState": "Unspecified",
"ChassisState": "Off",
"FW Version ID": "fw1110.00-3.53-1110.2503.20250109a (RB1110_025)",
"HostState": "Off",
"System IM": "50001001"
},
"User Data 1": {
"Section Version": "1",
"Sub-section type": "1",
"Created by": "bmc error logging",
"DESCRIPTION": "Failed to remove VPD for FRU: /xyz/openbmc_project/inventory/system/chassis/motherboard/tpm_wilson with error: Test Error",
"FileName": "/usr/src/debug/openpower-fru-vpd/1.0+git/vpd-manager/include/utility/vpd_specific_utility.hpp",
"FunctionName": "resetDataUnderPIM",
"InteranlRc": "0",
"UserData1": "",
"UserData2": ""
}
}
'''
Signed-off-by: RekhaAparna01 <[email protected]>
RekhaAparna01
force-pushed
the
pelForVpdSpecificUtility
branch
from
0c3f919 to
f83a2f4
Compare
SunnySrivastava1984
requested changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds code to log PEL in vpd_specific_utility file, in case of exceptions occurred while reset data under PIM and get expanded location code.
output: