Enable PEL for dbus_utility file #562
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RekhaAparna01
force-pushed
the
pelsForDbusUtility
branch
from
107c1f7 to
44b7ffd
Compare
RekhaAparna01
requested review from
jinuthomas,
PriyangaRamasamy,
souvik1914581,
SunnySrivastava1984 and
branupama
SunnySrivastava1984
approved these changes
Jan 7, 2025
SunnySrivastava1984
requested changes
Jan 7, 2025
| @@ -362,11 +363,12 @@ inline types::BiosAttributeCurrentValue | |||
| } | |||
| catch (const sdbusplus::exception::SdBusError& l_ex) | |||
| { | |||
| logging::logMessage( | |||
| EventLogger::createSyncPel( | |||
| types::ErrorType::InvalidVpdMessage, | |||
There was a problem hiding this comment.
Why invalid vpd message? You car logging it while catching DBus error.
RekhaAparna01
force-pushed
the
pelsForDbusUtility
branch
from
44b7ffd to
ca72926
Compare
This commit adds code to log a PEL in dbus_utility file, in case of
exceptions occurred while doing DBus calls.
output:
'''
root@p10bmc:~# peltool -i 0x5000000e
{
"Private Header": {
"Section Version": "1",
"Sub-section type": "0",
"Created by": "bmc vpd",
"Created at": "01/16/2025 04:47:34",
"Committed at": "01/16/2025 04:47:34",
"Creator Subsystem": "BMC",
"CSSVER": "",
"Platform Log Id": "0x5000000E",
"Entry Id": "0x5000000E",
"BMC Event Log Id": "14"
},
"User Header": {
"Section Version": "1",
"Sub-section type": "0",
"Log Committed by": "bmc error logging",
"Subsystem": "CEC Hardware - VPD Interface",
"Event Scope": "Entire Platform",
"Event Severity": "Informational Event",
"Event Type": "Miscellaneous, Informational Only",
"Action Flags": [
"Event not customer viewable",
"Report Externally"
],
"Host Transmission": "Not Sent",
"HMC Transmission": "Not Sent"
},
"Primary SRC": {
"Section Version": "1",
"Sub-section type": "1",
"Created by": "bmc vpd",
"SRC Version": "0x02",
"SRC Format": "0x55",
"Virtual Progress SRC": "False",
"I5/OS Service Event Bit": "False",
"Hypervisor Dump Initiated":"False",
"Backplane CCIN": "2E2D",
"Terminate FW Error": "False",
"Deconfigured": "False",
"Guarded": "False",
"Error Details": {
"Message": "A Dbus internal error occurred."
},
"Valid Word Count": "0x09",
"Reference Code": "BD554005",
"Hex Word 2": "00000055",
"Hex Word 3": "2E2D0010",
"Hex Word 4": "00000000",
"Hex Word 5": "00000000",
"Hex Word 6": "00000000",
"Hex Word 7": "00000000",
"Hex Word 8": "00000000",
"Hex Word 9": "00000000",
"Callout Section": {
"Callout Count": "1",
"Callouts": [{
"FRU Type": "Maintenance Procedure Required",
"Priority": "Mandatory, replace all with this type as a unit",
"Procedure": "BMC0001"
}]
}
},
"Extended User Header": {
"Section Version": "1",
"Sub-section type": "0",
"Created by": "bmc error logging",
"Reporting Machine Type": "9105-22A",
"Reporting Serial Number": "139EF60",
"FW Released Ver": "RB1110_025",
"FW SubSys Version": "fw1110.00-3.53",
"Common Ref Time": "00/00/0000 00:00:00",
"Symptom Id Len": "20",
"Symptom Id": "BD554005_2E2D0010"
},
"Failing MTMS": {
"Section Version": "1",
"Sub-section type": "0",
"Created by": "bmc error logging",
"Machine Type Model": "9105-22A",
"Serial Number": "139EF60"
},
"User Data 0": {
"Section Version": "1",
"Sub-section type": "1",
"Created by": "bmc error logging",
"BMCLoad": "0.80 0.95 0.87",
"BMCState": "Ready",
"BMCUptime": "0y 0d 0h 51m 27s",
"BootState": "Unspecified",
"ChassisState": "Off",
"FW Version ID": "fw1110.00-3.53-1110.2503.20250109a (RB1110_025)",
"HostState": "Off",
"System IM": "50001001"
},
"User Data 1": {
"Section Version": "1",
"Sub-section type": "1",
"Created by": "bmc error logging",
"DESCRIPTION": "Failed to get object subTree, error: Test Error: org.freedesktop.DBus.Error.AccessDenied: Operation not permitted",
"FileName": "/usr/src/debug/openpower-fru-vpd/1.0+git/vpd-manager/include/utility/dbus_utility.hpp",
"FunctionName": "getObjectSubTree",
"InteranlRc": "0",
"UserData1": "",
"UserData2": ""
}
}
'''
Signed-off-by: RekhaAparna01 <[email protected]>
RekhaAparna01
force-pushed
the
pelsForDbusUtility
branch
from
ca72926 to
6db36b5
Compare
| types::ErrorType::DbusFailure, types::SeverityType::Informational, | ||
| __FILE__, __FUNCTION__, 0, | ||
| "Failed to get property map, error: " + std::string(l_ex.what()), | ||
| std::nullopt, std::nullopt, std::nullopt, std::nullopt); |
There was a problem hiding this comment.
Not related to this PR, but I think we should have default std::optional<> = std::nullopt arguments for EventLogger::createSyncPel(), EventLogger::createAsyncPel() APIs, otherwise we have to pass std::nullopt in lot of calls.
souvik1914581
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds code to log a PEL in dbus_utility file, in case of exceptions occurred while doing DBus calls.
output: