forked from openbmc/openpower-vpd-parser
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PEL for Manager class #550
Open
RekhaAparna01
wants to merge
1
commit into
ibm-openbmc:1110
Choose a base branch
from
RekhaAparna01:pelsforManagerClass
base: 1110
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RekhaAparna01
requested review from
SunnySrivastava1984,
PriyangaRamasamy,
jinuthomas,
souvik1914581 and
branupama
December 18, 2024 17:36
RekhaAparna01
force-pushed
the
pelsforManagerClass
branch
2 times, most recently
from
December 19, 2024 04:49
4ebc826
to
2fffca6
Compare
RekhaAparna01
force-pushed
the
pelsforManagerClass
branch
2 times, most recently
from
January 2, 2025 12:13
52e6002
to
7648321
Compare
This commit adds code to log informational PELs in Manager class, in case of exceptions occurred while reading host state, performing vpd recollection and for public API's exposed under vpd-manager service. Also removed try catch block in manager constructor, as we are not doing any error handling. output: ''' root@p10bmc:/tmp# peltool -i 0x5000213a { "Private Header": { "Section Version": "1", "Sub-section type": "0", "Created by": "bmc vpd", "Created at": "01/02/2025 12:01:10", "Committed at": "01/02/2025 12:01:10", "Creator Subsystem": "BMC", "CSSVER": "", "Platform Log Id": "0x5000213A", "Entry Id": "0x5000213A", "BMC Event Log Id": "522" }, "User Header": { "Section Version": "1", "Sub-section type": "0", "Log Committed by": "bmc error logging", "Subsystem": "CEC Hardware - VPD Interface", "Event Scope": "Entire Platform", "Event Severity": "Informational Event", "Event Type": "Miscellaneous, Informational Only", "Action Flags": [ "Event not customer viewable", "Report Externally" ], "Host Transmission": "Not Sent", "HMC Transmission": "Not Sent" }, "Primary SRC": { "Section Version": "1", "Sub-section type": "1", "Created by": "bmc vpd", "SRC Version": "0x02", "SRC Format": "0x55", "Virtual Progress SRC": "False", "I5/OS Service Event Bit": "False", "Hypervisor Dump Initiated":"False", "Backplane CCIN": "2E2D", "Terminate FW Error": "False", "Deconfigured": "False", "Guarded": "False", "Error Details": { "Message": "A VPD data exception occurred." }, "Valid Word Count": "0x09", "Reference Code": "BD554001", "Hex Word 2": "00000055", "Hex Word 3": "2E2D0010", "Hex Word 4": "00000000", "Hex Word 5": "00000000", "Hex Word 6": "00000000", "Hex Word 7": "00000000", "Hex Word 8": "00000000", "Hex Word 9": "00000000" }, "Extended User Header": { "Section Version": "1", "Sub-section type": "0", "Created by": "bmc error logging", "Reporting Machine Type": " ", "Reporting Serial Number": " ", "FW Released Ver": "", "FW SubSys Version": "fw1110.00-3.34", "Common Ref Time": "00/00/0000 00:00:00", "Symptom Id Len": "20", "Symptom Id": "BD554001_2E2D0010" }, "Failing MTMS": { "Section Version": "1", "Sub-section type": "0", "Created by": "bmc error logging", "Machine Type Model": " ", "Serial Number": " " }, "User Data 0": { "Section Version": "1", "Sub-section type": "1", "Created by": "bmc error logging", "BMCLoad": "0.86 0.94 0.82", "BMCState": "Quiesced", "BMCUptime": "0y 0d 0h 28m 13s", "BootState": "Unspecified", "ChassisState": "Off", "FW Version ID": "fw1110.00-3.34-2-g45a17a06f3-dirty", "HostState": "Off", "System IM": "50001001" }, "User Data 1": { "Section Version": "1", "Sub-section type": "1", "Created by": "bmc error logging", "DESCRIPTION": "Test Error", "FileName": "/usr/src/debug/openpower-fru-vpd/1.0+git/vpd-manager/src/manager.cpp", "FunctionName": "deleteSingleFruVpd", "InteranlRc": "0", "UserData1": "", "UserData2": "" } } ''' Signed-off-by: RekhaAparna01 <[email protected]>
RekhaAparna01
force-pushed
the
pelsforManagerClass
branch
from
January 13, 2025 04:51
7648321
to
9ec42b1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds code to log informational PELs in Manager class, in case of exceptions occurred while reading host state, performing vpd recollection and for public API's exposed under vpd-manager service.
Also removed try catch block in manager constructor, as we are not doing any error handling.
output: