Remove errorlog association on PEL deletion #119
+18
−54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deepakala-k
force-pushed
the
1050_PEL_deleted
branch
2 times, most recently
from
67285d5 to
15207be
Compare
If a system guard's associated PEL is removed, the guard was skipped to be displayed in the GUI as the association is lost. The following error was displayed. ```Skipping to restore a given isolated hardware [23 01 00 02 00 03 00 ] : Due to failure to get BMC error log path by isolated hardware EID (aka PEL ID) [1342178283]``` As the guard still exists, it is better to display the guard without the errorlog association. The gui could show a system guard (predictive/ fatal) without the errorlog. Cherry picked the change from 1110. Tested and found it working as expected Signed-off-by: deepakalak <[email protected]>
deepakala-k
force-pushed
the
1050_PEL_deleted
branch
from
15207be to
2791fb8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a system guard's associated PEL is removed, the guard was skipped to be displayed in the GUI as the association is lost. The following error was displayed.
Skipping to restore a given isolated hardware [23 01 00 02 00 03 00 ] : Due to failure to get BMC error log path by isolated hardware EID (aka PEL ID) [1342178283]
As the guard still exists, it is better to display the guard without the errorlog association. The gui could show a system guard (predictive/ fatal) without the errorlog.
Currently the PEL associated with the guard cannot be removed. This is an extra check on top of it.