Update Geocoder Package #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miles-grant-ibigroup
force-pushed
the
update-otp-ui
branch
from
82c94bd to
a972822
Compare
daniel-heppner-ibigroup
approved these changes
May 31, 2023
| .toLowerCase() | ||
| .includes(otherFeature?.properties?.name.toLowerCase()) || | ||
| .includes((otherFeature?.properties?.name || '').toLowerCase()) || |
There was a problem hiding this comment.
I won't block this PR based on this since it was "broken" before, but I think that we should be more careful about using optional chaining to solve problems when our types aren't correct.
There was a problem hiding this comment.
This is for handling incorrect data coming back from the server. The types are correct, the server is wrong
daniel-heppner-ibigroup
assigned miles-grant-ibigroup and unassigned daniel-heppner-ibigroup
philip-cline
approved these changes
Jun 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows for OTP2 Geocoder to work properly