Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve instructions for last portion of walk leg #287

Open
wants to merge 6 commits into
base: dev
Choose a base branch
from
Open

Improve instructions for last portion of walk leg #287

wants to merge 6 commits into from

Conversation

binh-dam-ibigroup
Copy link
Collaborator

Checklist

  • Appropriate branch selected (all PRs must first be merged to dev before they can be merged to master)
  • Any modified or new methods or classes have helpful JavaDoc and code is thoroughly commented
  • [na] The description lists all applicable issues this PR seeks to resolve
  • [na] The description lists any configuration setting(s) that differ from the default settings
  • All tests and CI builds passing

Description

This PR improves instructions on walk legs after the last turn is taken:

  • "Continue" instructions, instead of "NO_INSTRUCTION", are given on the last street/sidewalk/path,
  • If the destination is away from the last street/sidewalk/path in an itinerary, an instruction: "Your destination is in the vicinity" is emitted when the traveler reaches the end of the leg shape. (An extra step is added behind the scenes to accommodate that).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@br648 br648 Awaiting requested review from br648

At least 2 approving reviews are required to merge this pull request.

Assignees

@br648 br648

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@binh-dam-ibigroup @br648