Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apply desired joint torque passed from the frankapy client #18

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

Ruthrash
Copy link

@Ruthrash Ruthrash commented Sep 13, 2023

This PR adds a new skill that requests franka-interface server to apply desired torque to the joints.

@Ruthrash Ruthrash changed the title Add a new skill to apply desired joint torque passed from the frankapy client apply desired joint torque passed from the frankapy client Sep 13, 2023
Copy link
Contributor

@mohitsharma0690 mohitsharma0690 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There seem to be too many files that shouldn't be added here. Can you please take a look.

bash_scripts/start_control_pc (copy).sh Outdated Show resolved Hide resolved
bash_scripts/start_control_pc.sh Outdated Show resolved Hide resolved
bash_scripts/start_control_pc.sh Show resolved Hide resolved
frankapy/franka_arm.py Show resolved Hide resolved
frankapy/franka_arm.py Outdated Show resolved Hide resolved
scripts/reset_arm.py Outdated Show resolved Hide resolved
frankapy/franka_interface_common_definitions.py Outdated Show resolved Hide resolved
frankapy/franka_arm.py Outdated Show resolved Hide resolved
bash_scripts/start_franka_ros_interface_on_control_pc.sh Outdated Show resolved Hide resolved
bash_scripts/start_franka_gripper_on_control_pc.sh Outdated Show resolved Hide resolved
@Ruthrash
Copy link
Author

Ruthrash commented Jan 23, 2024

Hey @mohitsharma0690! Apologies for getting so late to reply, I was travelling for the most part of the time after your change requests and I didn't have access to the franka robot.

Also, so sorry for adding changes not relevant to this PR. I have removed them based on your comments.

Thanks so much for your comments, I have incoporated the changes you have asked. Please get back to me when you could. Thanks!

@Ruthrash
Copy link
Author

Also, I have an example joint_torque_control.py script that applies zero joint torque(gravity compensation) that can act as a test case for this feature. Do let me know if you think I should add it to this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants