Fix size prediction when the focused window and cursor are on different monitors #9116
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vaxerski
reviewed
Jan 19, 2025
| @@ -1084,7 +1084,7 @@ Vector2D CHyprDwindleLayout::predictSizeForNewWindowTiled() { | |||
| // create a fake node | |||
| SDwindleNodeData node; | |||
|
|
|||
| if (!candidate) | |||
| if (!candidate || candidate->monitorID() != g_pCompositor->m_pLastMonitor->ID) | |||
There was a problem hiding this comment.
this will always predict the full monitor even if it is populated. That's not the way to do it, we probably should find a candidate on the other monitor and go from that
There was a problem hiding this comment.
You're right and this is the right way, but even when it predicts bigger than needed, I don't see any artifacts or bugs. Maybe I'm not seeing something because logically you should expect something to go wrong if the predicted size is wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your PR, what does it fix/add?
Fixes #9057
Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)
No
Is it ready for merging, or does it need work?
Ready