Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3.13 #339

Merged
merged 16 commits into from
Dec 12, 2024
Merged

Python 3.13 #339

merged 16 commits into from
Dec 12, 2024

Conversation

ericpre
Copy link
Member

@ericpre ericpre commented Nov 27, 2024

Progress of the PR

  • Add python 3.13 to CI,
  • fix some numpy deprecation,
  • fix warning in the test suite,
  • [n/a] update docstring (if appropriate),
  • [n/a] update user guide (if appropriate),
  • add a changelog entry in the upcoming_changes folder (see upcoming_changes/README.rst),
  • Check formatting of the changelog entry (and eventual user guide changes) in the docs/readthedocs.org:rosettasciio build of this PR (link in github checks)
  • [n/a] add tests,
  • ready for review.

rsciio/tests/test_tia.py Dismissed Show dismissed Hide dismissed
Copy link

codecov bot commented Nov 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.84%. Comparing base (332412f) to head (160807e).
Report is 21 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #339      +/-   ##
==========================================
- Coverage   87.88%   87.84%   -0.05%     
==========================================
  Files          85       85              
  Lines       11241    11242       +1     
  Branches     2294     2082     -212     
==========================================
- Hits         9879     9875       -4     
- Misses        863      868       +5     
  Partials      499      499              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@CSSFrancis CSSFrancis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like some good updates. LGTM

@CSSFrancis CSSFrancis merged commit 623328f into hyperspy:main Dec 12, 2024
32 of 33 checks passed
@ericpre ericpre mentioned this pull request Dec 16, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants