Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pectra devnet 5 interop + execution spec tests #8080

Draft
wants to merge 24 commits into
base: main
Choose a base branch
from

Conversation

siladu
Copy link
Contributor

@siladu siladu commented Jan 6, 2025

Run #8044 against https://github.com/ethereum/execution-spec-tests/releases/tag/pectra-devnet-5%40v1.1.0

59264 tests completed, 2593 failed, 8027 skipped

Fixes #8070

siladu and others added 22 commits December 17, 2024 22:24
Signed-off-by: Simon Dudley <[email protected]>
…or each fork

This isolates defaulting to MainnetProtocolSpecs and reduces blast radius for tests

Signed-off-by: Simon Dudley <[email protected]>
Signed-off-by: Simon Dudley <[email protected]>
Signed-off-by: Simon Dudley <[email protected]>
Signed-off-by: Daniel Lehrner <[email protected]>
Signed-off-by: Daniel Lehrner <[email protected]>
Signed-off-by: Simon Dudley <[email protected]>
Signed-off-by: Simon Dudley <[email protected]>
- Add asMap for blobSchedule so it appears in admin_nodeInfo
- Prememptively add OsakaTargetingGasLimitCalculator and wire in the max blob count

Add blobschedule to mainnet.json to be explicit, since the code will default to the same values anyway

Signed-off-by: Simon Dudley <[email protected]>
…nstead of responding with error

Would fix hyperledger#8055 but unit tests still todo

Signed-off-by: Simon Dudley <[email protected]>
https://github.com/ethereum/EIPs/pull/9097/files
https://github.com/ethereum/EIPs/pull/9098/files
https://github.com/ethereum/EIPs/pull/9116/files

Signed-off-by: garyschulte <[email protected]>

adjust unit test gas costs, fix offset-by-one bug in the discount table

Signed-off-by: garyschulte <[email protected]>

implement bump in gas cost for bls map functions according to ethereum/EIPs@92c94cf

Signed-off-by: garyschulte <[email protected]>

using Pawel's suggested discount table from ethereum/EIPs#9116 (comment)

Signed-off-by: garyschulte <[email protected]>

use bls pairing costs from https://github.com/ethereum/EIPs/pull/9098/files

Signed-off-by: garyschulte <[email protected]>

remove MUL per ethereum/EIPs#8945

Signed-off-by: garyschulte <[email protected]>

fix g1 msm max discount case, add g2 msm max discount case

Signed-off-by: garyschulte <[email protected]>

remove bls mul ops from benchmark subcommand

Signed-off-by: garyschulte <[email protected]>

use besu-native 1.1.1

Signed-off-by: garyschulte <[email protected]>
* prague fee market for blob gas

Signed-off-by: garyschulte <[email protected]>

* Fix wiring and unit test

Signed-off-by: Simon Dudley <[email protected]>

---------

Signed-off-by: garyschulte <[email protected]>
Signed-off-by: Simon Dudley <[email protected]>
Co-authored-by: Simon Dudley <[email protected]>
…params instead of responding with error"

This reverts commit c5e564c.

Signed-off-by: Simon Dudley <[email protected]>
* don't throw if all the gasprice params are specified

Signed-off-by: Sally MacFarlane <[email protected]>

---------

Signed-off-by: Sally MacFarlane <[email protected]>
Revert "Rename targetBlobCount to targetBlobsPerBlock (hyperledger#7981)"

This reverts commit 1671306.

Signed-off-by: Simon Dudley <[email protected]>

Revert "EIP-7742: Add target_blob_count to block header (hyperledger#7808)"

This reverts commit f855d5b.

Signed-off-by: Simon Dudley <[email protected]>
@siladu siladu force-pushed the pectra-devnet-5-interop_execution-spec-tests branch from e2105b6 to f759b77 Compare January 7, 2025 01:28
@siladu siladu changed the title Pectra devnet 5 interop execution spec tests Pectra devnet 5 interop + execution spec tests Jan 7, 2025
@siladu siladu force-pushed the pectra-devnet-5-interop_execution-spec-tests branch from f759b77 to 5efd396 Compare January 14, 2025 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pectra Devnet 5 Hive / Execution Spec Tests
4 participants