add parentBeaconBlockRoot field #2007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thinkAfCod
force-pushed
the
feature/add_field
branch
from
eaa966b to
93c6e5d
Compare
thinkAfCod
force-pushed
the
feature/add_field
branch
from
93c6e5d to
15049ee
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2007 +/- ##
============================================
+ Coverage 69.19% 69.22% +0.03%
Complexity 3117 3117
============================================
Files 493 493
Lines 13078 13090 +12
Branches 1688 1692 +4
============================================
+ Hits 9049 9062 +13
+ Misses 3538 3537 -1
Partials 491 491 ☔ View full report in Codecov by Sentry. |
|
@thinkAfCod LGTM, can you provide the spec reference for this? Edited: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
After Ethereum supports -4844, the response from eth_getBlockByNumber api will include parentBeaconBlockRoot.
Where should the reviewer start?
PR is quite short
Why is it needed?
This is the necessary update for EIP-4844.