-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Calculate baseFeePerBlobGas value #2006
Conversation
Signed-off-by: Nischal Sharma <[email protected]>
Signed-off-by: Nischal Sharma <[email protected]>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2006 +/- ##
============================================
+ Coverage 68.94% 69.20% +0.25%
- Complexity 3089 3117 +28
============================================
Files 493 493
Lines 12922 13078 +156
Branches 1661 1688 +27
============================================
+ Hits 8909 9050 +141
- Misses 3526 3537 +11
- Partials 487 491 +4 ☔ View full report in Codecov by Sentry. |
core/src/main/java/org/web3j/protocol/core/methods/response/EthBlock.java
Show resolved
Hide resolved
which version will include this feature? |
We will be releasing it in next release 4.11.1 |
Signed-off-by: Nischal Sharma <[email protected]>
LGTM |
When will 4.11.1 release? We need 4844 support Dencun upgrade. |
Should be complete by next week, we need to add other things in web3j-cli and want to release everything together. Also since web3j is now migrating to Hyperledger web3j, we will be making changes to all the repo and include it in 4.11.1 release |
What does this PR do?
Add a new feature to get baseFeePerBlobGas value
Where should the reviewer start?
review all files, start with BlobFee.java file
Why is it needed?
required