Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: reduce clippy warnings #5254

Merged
merged 4 commits into from
Nov 27, 2024
Merged

chore: reduce clippy warnings #5254

merged 4 commits into from
Nov 27, 2024

Conversation

s8sato
Copy link
Contributor

@s8sato s8sato commented Nov 26, 2024 •
edited
Loading

Context

  • There have been some clippy lint warnings left unresolved

Solution

  • Fix, expect, or allow the warnings

Checklist

  • I've read CONTRIBUTING.md.
  • All review comments have been resolved.
  • All CI checks pass.

@s8sato s8sato marked this pull request as ready for review November 26, 2024 11:12
@s8sato s8sato self-assigned this Nov 26, 2024
@s8sato
chore: reduce clippy warnings
03219f6 
Signed-off-by: Shunkichi Sato <[email protected]>
@s8sato s8sato enabled auto-merge (squash) November 26, 2024 11:55
aoyako
aoyako previously approved these changes Nov 26, 2024
View reviewed changes
mversic
mversic reviewed Nov 27, 2024
View reviewed changes
crates/iroha_data_model/src/query/builder.rs Outdated
@@ -39,6 +39,7 @@ pub trait QueryExecutor {
/// # Errors
///
/// Returns an error if the query execution fails.
#[expect(clippy::type_complexity)]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

create QueryResult (or just Result) type instead

Copy link
Contributor Author

@s8sato s8sato Nov 27, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can I leave this to you @DCNick3 ? I don't want to introduce new type aliases or structs right now. Also, would you address the newly introduced warnings in #5242 ?

@mversic mversic requested a review from aoyako November 27, 2024 10:46
@s8sato s8sato merged commit 0e096d5 into hyperledger-iroha:main Nov 27, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aoyako aoyako aoyako approved these changes

@mversic mversic mversic approved these changes

@SamHSmith SamHSmith Awaiting requested review from SamHSmith SamHSmith is a code owner

@outoftardis outoftardis Awaiting requested review from outoftardis outoftardis is a code owner

@0x009922 0x009922 Awaiting requested review from 0x009922 0x009922 is a code owner

@DCNick3 DCNick3 Awaiting requested review from DCNick3 DCNick3 is a code owner

@dima74 dima74 Awaiting requested review from dima74 dima74 is a code owner

Assignees

@s8sato s8sato

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@s8sato @mversic @aoyako