Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add grant and revoke tests #5216

Merged
merged 1 commit into from
Nov 26, 2024
Merged

test: add grant and revoke tests #5216

merged 1 commit into from
Nov 26, 2024

Conversation

alexstroke1
Copy link
Contributor

@alexstroke1 alexstroke1 commented Nov 2, 2024 •
edited
Loading

Context

  • Improved test coverage for Iroha CLI permission management commands.
  • Enhanced error handling and code readability.
  • Added new tests for edge cases (invalid permissions, nonexistent accounts, data format errors).

Solution

  • Scenarios for granting and revoking permissions.

Checklist

  • I've read CONTRIBUTING.md.
  • (optional) I've written unit tests for the code changes.
  • All review comments have been resolved.
  • All CI checks pass.

@alexstroke1 alexstroke1 changed the title tests: add grant and revoke tests test: add grant and revoke tests Nov 5, 2024
@alexstroke1 alexstroke1 force-pushed the astrokov branch 6 times, most recently from 315dc18 to 0732e3b Compare November 20, 2024 08:30
@alexstroke1 alexstroke1 marked this pull request as ready for review November 20, 2024 11:10
@s8sato s8sato self-assigned this Nov 21, 2024
@mversic mversic self-requested a review November 26, 2024 07:42
@alexstroke1 alexstroke1 force-pushed the astrokov branch 2 times, most recently from 91fb307 to bf1eb7d Compare November 26, 2024 07:51
@mversic mversic merged commit 7cb55e4 into hyperledger-iroha:main Nov 26, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@s8sato s8sato s8sato approved these changes

@SamHSmith SamHSmith Awaiting requested review from SamHSmith SamHSmith is a code owner

@outoftardis outoftardis Awaiting requested review from outoftardis outoftardis is a code owner

@0x009922 0x009922 Awaiting requested review from 0x009922 0x009922 is a code owner

@DCNick3 DCNick3 Awaiting requested review from DCNick3 DCNick3 is a code owner

@dima74 dima74 Awaiting requested review from dima74 dima74 is a code owner

@mversic mversic Awaiting requested review from mversic mversic is a code owner

Assignees

@s8sato s8sato

Labels
Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexstroke1 @mversic @s8sato