-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(wasm_samples): pre-compiled wasm_samples
#5123
build(wasm_samples): pre-compiled wasm_samples
#5123
Conversation
Signed-off-by: 0x009922 <[email protected]>
Signed-off-by: 0x009922 <[email protected]>
Signed-off-by: 0x009922 <[email protected]>
I notice you didn't remove the wasm build from the build scripts such as |
Yes, I left it as-is. It just works, and I don't know how to be with it: shall |
Co-authored-by: Marin Veršić <[email protected]> Signed-off-by: 0x009922 <[email protected]>
yeah, it's ok. Building |
Signed-off-by: 0x009922 <[email protected]>
Signed-off-by: 0x009922 <[email protected]>
Signed-off-by: 0x009922 <[email protected]>
Context
Split from #5087
There are numerous invocations of
iroha_wasm_builder
library interface from within tests/benches/examples.Problems:
-C instrument-coverage
rustc flag (refactor!: black-box integration tests #5087 (comment)), which is set when we run tests with coverage.Solution
iroha_wasm_builder
from tests. It makes possible to run all tests with coverage in a single CI run (that was achieved in refactor!: black-box integration tests #5087 (comment))rule them allbuild allwasm_samples
, both locally and CIiroha_test_samples::load_sample_wasm("default_executor") -> WasmSmartContract
Migration Guide (optional)
For developers:
./scripts/build_wasm_samples.sh
is a single command for you to prepare all WASMs anddefaults/executor.wasm
. You need to run it before running tests that depend on WASM samples.Review notes (optional)
None
Checklist
CONTRIBUTING.md
.