-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(queries): Report amount of remaining items in query #5016
Merged
mversic
merged 3 commits into
hyperledger-iroha:main
from
DCNick3:report-query-result-count
Sep 4, 2024
Merged
feat(queries): Report amount of remaining items in query #5016
mversic
merged 3 commits into
hyperledger-iroha:main
from
DCNick3:report-query-result-count
Sep 4, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DCNick3
requested review from
s8sato,
mversic,
SamHSmith,
outoftardis,
Erigara,
0x009922 and
dima74
as code owners
August 28, 2024 07:40
DCNick3
force-pushed
the
report-query-result-count
branch
3 times, most recently
from
August 28, 2024 20:49
76149b1
to
7a70461
Compare
How this will work for SDKs? To get total amount of items in the query they need to add number of remaining items (from the |
Yes, this is what rust SDK is also doing |
Erigara
previously approved these changes
Sep 3, 2024
mversic
previously approved these changes
Sep 4, 2024
Signed-off-by: ⭐️NINIKA⭐️ <[email protected]>
Signed-off-by: ⭐️NINIKA⭐️ <[email protected]>
mversic
force-pushed
the
report-query-result-count
branch
from
September 4, 2024 03:33
7a70461
to
e71b780
Compare
…sedIterator::remaining` to hopefully be more clear Signed-off-by: ⭐️NINIKA⭐️ <[email protected]>
mversic
approved these changes
Sep 4, 2024
Erigara
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This PR allows the client to inspect the amount of items that is returned by the query without requesting all batches.
Closes #4984
Solution
ExactSizeIterator
implementation applied to the pagination combinator. Filtering is not a problem, because we currently eagerly collect all items into a vector before returning anything.ExactSizeIterator
onQueryIterator
pretty naturally.Checklist
CONTRIBUTING.md
.