-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: replace Duration
with u64
in schema
#4841
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mversic
requested review from
s8sato,
SamHSmith,
outoftardis,
Erigara,
0x009922,
DCNick3 and
dima74
as code owners
July 12, 2024 11:16
mversic
commented
Jul 12, 2024
mversic
force-pushed
the
time_trigger_fix
branch
from
July 12, 2024 11:20
e8260e3
to
cade53a
Compare
What is your motivation for removing |
because it was a pain to use and incorrect. In schema we had an entry: "Duration": {
"Tuple": [
"u64",
"u32"
]
} but in "filter": {
"Time": {
"Schedule": {
"start": {
"secs": 1790774026,
"nanos": 0
},
"period": {
"secs": 1,
"nanos": 0
}
}
}
} we can consider restoring it but it has to be done properly |
Erigara
previously approved these changes
Jul 15, 2024
nxsaken
previously approved these changes
Jul 15, 2024
nxsaken
force-pushed
the
time_trigger_fix
branch
from
July 15, 2024 11:18
cade53a
to
4c14031
Compare
dima74
previously approved these changes
Jul 15, 2024
Signed-off-by: Marin Veršić <[email protected]>
mversic
force-pushed
the
time_trigger_fix
branch
from
July 15, 2024 14:49
4c14031
to
dca010e
Compare
dima74
approved these changes
Jul 15, 2024
nxsaken
approved these changes
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Duration
withu64
inschema.json
Linked issue
Closes #{issue_number}
Benefits
Checklist
CONTRIBUTING.md