Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tests): correctly list asset definitions in CLI tests #4836

Merged
merged 1 commit into from
Jul 12, 2024
Merged

fix(tests): correctly list asset definitions in CLI tests #4836

merged 1 commit into from
Jul 12, 2024

Conversation

mversic
Copy link
Contributor

@mversic mversic commented Jul 11, 2024 •
edited
Loading

Description

  • fix client cli pytests
  • rename --asset-id to --id in client CLI
  • add asset definition subparameter in CLI

Linked issue

Closes #{issue_number}

Benefits

Checklist

  • I've read CONTRIBUTING.md
  • I've used the standard signed-off commit format (or will squash just before merging)
  • All applicable CI checks pass (or I promised to make them pass later)
  • (optional) I've written unit tests for the code changes
  • I replied to all comments after code review, marking all implemented changes with thumbs up

@mversic mversic enabled auto-merge (squash) July 11, 2024 14:16
@s8sato s8sato self-assigned this Jul 12, 2024
@mversic mversic merged commit 06bd93a into hyperledger-iroha:main Jul 12, 2024
12 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@s8sato s8sato s8sato approved these changes

@Erigara Erigara Erigara approved these changes

@nxsaken nxsaken nxsaken approved these changes

@SamHSmith SamHSmith Awaiting requested review from SamHSmith SamHSmith is a code owner

@outoftardis outoftardis Awaiting requested review from outoftardis outoftardis is a code owner

@0x009922 0x009922 Awaiting requested review from 0x009922 0x009922 is a code owner

@DCNick3 DCNick3 Awaiting requested review from DCNick3 DCNick3 is a code owner

@dima74 dima74 Awaiting requested review from dima74 dima74 is a code owner

Assignees

@Erigara Erigara

@mversic mversic

@s8sato s8sato

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mversic @nxsaken @Erigara @s8sato