-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: speicfy on-chain parameters explicitly in genesis #4812
feat!: speicfy on-chain parameters explicitly in genesis #4812
Conversation
the downside of this approach is that |
I see, another downside is that custom parameters is not registered yet. |
Signed-off-by: Shanin Roman <[email protected]>
Signed-off-by: Shanin Roman <[email protected]>
Signed-off-by: Shanin Roman <[email protected]>
6bde1a2
to
54b6739
Compare
We can make Upgrade be the first instruction but not check it for executor limits. Then apply parameters and then all other |
Regestring executor itself is not that heavy. |
Also it's possible to set parameters on executor migration. But I like the simplicity of providing them through |
Description
Currently it's not possible to submit genesis which doesn't pass under default parameter values (i.e. large genesis).
This PR fixes that allowing to specify parameters inside genesis.json so that they are applied before processing rest of instructions.