Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(client): allow turbofish with multiple Instructions #4805

Merged

Conversation

nxsaken
Copy link
Contributor

@nxsaken nxsaken commented Jul 5, 2024

Description

Converts impl Instruction to an explicit type parameter in functions accepting multiple instructions.

Benefits

Lets users avoid converting heterogeneous instructions to InstructionBoxes in a separate variable before submitting to a client, which is more ergonomic.

Checklist

  • I've read CONTRIBUTING.md
  • I've used the standard signed-off commit format (or will squash just before merging)
  • All applicable CI checks pass (or I promised to make them pass later)
  • (optional) I've written unit tests for the code changes
  • I replied to all comments after code review, marking all implemented changes with thumbs up

@nxsaken nxsaken self-assigned this Jul 5, 2024
@nxsaken nxsaken force-pushed the refactor/turbofishy-instructionbox branch from 9063169 to 8e65e87 Compare July 8, 2024 06:26
@nxsaken nxsaken force-pushed the refactor/turbofishy-instructionbox branch from 8e65e87 to f558a5f Compare July 8, 2024 12:00
@mversic mversic merged commit 3b5d6b2 into hyperledger-iroha:main Jul 8, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants