refactor!: fix naming convention for assets and permissions #4741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mversic
requested review from
s8sato,
SamHSmith,
outoftardis,
Erigara,
0x009922,
DCNick3 and
dima74
as code owners
mversic
force-pushed
the
fix_asset_naming
branch
2 times, most recently
from
c2c6282 to
4fb6a12
Compare
dima74
reviewed
Jun 18, 2024
mversic
force-pushed
the
fix_asset_naming
branch
from
4fb6a12 to
179bbd6
Compare
dima74
previously approved these changes
Jun 19, 2024
mversic
force-pushed
the
fix_asset_naming
branch
4 times, most recently
from
ea64bc1 to
bc7756f
Compare
mversic
commented
Jun 19, 2024
mversic
commented
Jun 19, 2024
mversic
force-pushed
the
fix_asset_naming
branch
7 times, most recently
from
d74b1db to
41efd97
Compare
mversic
force-pushed
the
fix_asset_naming
branch
7 times, most recently
from
4e772ab to
38c50c5
Compare
github-actions
bot
added
the
config-changes
mversic
force-pushed
the
fix_asset_naming
branch
7 times, most recently
from
618b548 to
47cfe1c
Compare
mversic
added
config-changes
mversic
force-pushed
the
fix_asset_naming
branch
3 times, most recently
from
b1dfab9 to
df7f6c0
Compare
Signed-off-by: Marin Veršić <[email protected]>
mversic
force-pushed
the
fix_asset_naming
branch
from
df7f6c0 to
0a1fd80
Compare
0x009922
approved these changes
Jun 28, 2024
nxsaken
approved these changes
Jun 28, 2024
hollermay
pushed a commit
to hollermay/iroha
that referenced
this pull request
Jun 28, 2024
…ger-iroha#4741) * rename Permission::id to Permission::name * rename AssetValueType to AssetType Signed-off-by: Marin Veršić <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Permission::idtoPermission::nameAssetValueTypetoAssetTypeLinked issue
Closes #{issue_number}
Benefits
Checklist
CONTRIBUTING.md