Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: implement built-in vs custom on-chain parameters #4731

Merged
merged 1 commit into from
Jun 28, 2024
Merged

feat!: implement built-in vs custom on-chain parameters #4731

merged 1 commit into from
Jun 28, 2024

Conversation

mversic
Copy link
Contributor

@mversic mversic commented Jun 14, 2024 •
edited
Loading

Description

  • remove NewParametere ISI
  • remove on-chain parameters from configuration
  • strong type on-chain parameters
  • removed MetadataLimits and LenghtLimits as built-in on-chain parameters (they can be defined as custom)

Next PR will introduce Custom parameters

Linked issue

Closes #{issue_number}

Benefits

Checklist

  • I've read CONTRIBUTING.md
  • I've used the standard signed-off commit format (or will squash just before merging)
  • All applicable CI checks pass (or I promised to make them pass later)
  • (optional) I've written unit tests for the code changes
  • I replied to all comments after code review, marking all implemented changes with thumbs up

@github-actions github-actions bot added api-changes Changes in the API for client libraries config-changes Changes in configuration and start up of the Iroha labels Jun 14, 2024
@github-actions GitHub Actions
Copy link

@BAStos525

@mversic mversic force-pushed the on_chain_params branch 3 times, most recently from 268b074 to 9a0be89 Compare June 14, 2024 12:36
0x009922
0x009922 reviewed Jun 18, 2024
View reviewed changes
data_model/src/param.rs Outdated Show resolved Hide resolved
data_model/src/param.rs Outdated Show resolved Hide resolved
data_model/src/query/mod.rs Outdated Show resolved Hide resolved
core/src/tx.rs Outdated Show resolved Hide resolved
core/src/sumeragi/main_loop.rs Outdated Show resolved Hide resolved
core/src/state.rs Outdated Show resolved Hide resolved
core/src/state.rs Outdated Show resolved Hide resolved
core/src/smartcontracts/isi/account.rs Outdated Show resolved Hide resolved
dima74
dima74 reviewed Jun 19, 2024
View reviewed changes
client/examples/register_1000_triggers.rs Show resolved Hide resolved
client/tests/integration/upgrade.rs Show resolved Hide resolved
core/benches/validation.rs Outdated Show resolved Hide resolved
core/src/smartcontracts/isi/world.rs Outdated Show resolved Hide resolved
@mversic mversic force-pushed the on_chain_params branch 6 times, most recently from 7274c13 to f682e7c Compare June 19, 2024 21:32
Erigara
Erigara reviewed Jun 20, 2024
View reviewed changes
client/examples/register_1000_triggers.rs Show resolved Hide resolved
client/tests/integration/set_parameter.rs Outdated Show resolved Hide resolved
client/tests/integration/smartcontracts/executor_with_custom_parameter/src/lib.rs Show resolved Hide resolved
client/tests/integration/smartcontracts/executor_with_custom_parameter/src/lib.rs Outdated Show resolved Hide resolved
client/tests/integration/smartcontracts/executor_with_custom_parameter/src/lib.rs Outdated Show resolved Hide resolved
client/tests/integration/upgrade.rs Outdated Show resolved Hide resolved
client/tests/integration/upgrade.rs Outdated Show resolved Hide resolved
configs/swarm/genesis.json Show resolved Hide resolved
core/benches/blocks/common.rs Outdated Show resolved Hide resolved
Erigara
Erigara reviewed Jun 20, 2024
View reviewed changes
core/src/smartcontracts/wasm.rs Outdated Show resolved Hide resolved
data_model/src/account.rs Show resolved Hide resolved
client/tests/integration/smartcontracts/executor_with_custom_parameter/src/lib.rs Outdated Show resolved Hide resolved
data_model/src/param.rs Outdated Show resolved Hide resolved
configs/swarm/genesis.json Show resolved Hide resolved
@mversic mversic changed the title fix!: remove on-chain parameters from config and remove NewParameter ISI feat!: implement built-in vs custom on-chain parameters Jun 24, 2024
@mversic mversic marked this pull request as ready for review June 24, 2024 09:32
@mversic mversic force-pushed the on_chain_params branch 2 times, most recently from 5a6ed74 to 3e3ab4e Compare June 24, 2024 19:57
@mversic mversic requested review from Erigara, dima74 and 0x009922 June 27, 2024 12:55
@mversic mversic force-pushed the on_chain_params branch 4 times, most recently from 8cac0a0 to 4629a91 Compare June 27, 2024 15:55
@mversic mversic force-pushed the on_chain_params branch 3 times, most recently from 6f2d106 to 71e3576 Compare June 28, 2024 08:49
0x009922
0x009922 reviewed Jun 28, 2024
View reviewed changes
Copy link
Contributor

@0x009922 0x009922 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A slight issue with ::Delete event.

Otherwise, LGTM.

data_model/src/events/data/events.rs Outdated Show resolved Hide resolved
data_model/src/events/data/events.rs Outdated Show resolved Hide resolved
data_model/src/events/data/events.rs Outdated Show resolved Hide resolved
Erigara
Erigara reviewed Jun 28, 2024
View reviewed changes
Copy link
Contributor

@Erigara Erigara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please ping when you will resolve conflicts

core/src/state.rs Show resolved Hide resolved
@mversic mversic force-pushed the on_chain_params branch 3 times, most recently from 0678da7 to c89e973 Compare June 28, 2024 10:44
@mversic mversic requested review from Erigara and 0x009922 June 28, 2024 10:45
@mversic mversic merged commit b69230b into hyperledger-iroha:main Jun 28, 2024
12 of 13 checks passed
@mversic mversic deleted the on_chain_params branch June 28, 2024 11:15
hollermay pushed a commit to hollermay/iroha that referenced this pull request Jun 28, 2024
@mversic @hollermay
feat!: implement built-in vs custom on-chain parameters (hyperledger-…
0249a8a 
…iroha#4731)

* remove `NewParameter` ISI
* remove on-chain parameters from configuration
* strong type on-chain parameters
* removed `MetadataLimits` and `LenghtLimits` as built-in on-chain parameters
* provide facility to define custom parameters in executor

Signed-off-by: Marin Veršić <[email protected]>
hollermay added a commit to hollermay/iroha that referenced this pull request Jun 28, 2024
@hollermay
feat!: implement built-in vs custom on-chain parameters (hyperledger-…
b1c7e5e 
…iroha#4731)

* remove `NewParameter` ISI
* remove on-chain parameters from configuration
* strong type on-chain parameters
* removed `MetadataLimits` and `LenghtLimits` as built-in on-chain parameters
* provide facility to define custom parameters in executor

Signed-off-by: Marin Veršić <[email protected]>
Signed-off-by: hollermay <[email protected]>
@DCNick3 DCNick3 mentioned this pull request Dec 2, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Erigara Erigara Erigara approved these changes

@dima74 dima74 dima74 approved these changes

@s8sato s8sato Awaiting requested review from s8sato s8sato is a code owner

@SamHSmith SamHSmith Awaiting requested review from SamHSmith

@outoftardis outoftardis Awaiting requested review from outoftardis outoftardis is a code owner

@DCNick3 DCNick3 Awaiting requested review from DCNick3 DCNick3 is a code owner

@0x009922 0x009922 Awaiting requested review from 0x009922 0x009922 is a code owner

Assignees

@dima74 dima74

@Erigara Erigara

@0x009922 0x009922

@mversic mversic

Labels
api-changes Changes in the API for client libraries config-changes Changes in configuration and start up of the Iroha
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mversic @dima74 @Erigara @0x009922