refactor: migrate to axum #4718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Erigara
requested review from
s8sato,
mversic,
SamHSmith,
outoftardis,
0x009922,
DCNick3,
VAmuzing and
dima74
as code owners
Erigara
commented
Jun 11, 2024
0x009922
reviewed
Jun 13, 2024
There was a problem hiding this comment.
Finally!
But Torii tests are failing. Thanks to @AlexStroke, the reports are quite informative.
Tests are fixed + added extra test for different wrong body errors, the problem was mainly because pytests didn't set proper headers. |
|
@AlexStroke please take a look at torii pytests |
Erigara
force-pushed
the
migrate_axum
branch
2 times, most recently
from
20e867b to
4169e77
Compare
Erigara
force-pushed
the
migrate_axum
branch
2 times, most recently
from
0dfa6d1 to
8f909ae
Compare
|
Ignore first commit, it's extracted in separate PR and here only to make unit tests work |
Erigara
force-pushed
the
migrate_axum
branch
3 times, most recently
from
dfa26fe to
728921f
Compare
DCNick3
reviewed
Jun 26, 2024
DCNick3
previously approved these changes
Jun 28, 2024
DCNick3
previously approved these changes
Jun 28, 2024
0x009922
previously approved these changes
Jul 1, 2024
DCNick3
previously approved these changes
Jul 1, 2024
0x009922
previously approved these changes
Jul 2, 2024
Signed-off-by: Shanin Roman <[email protected]>
Signed-off-by: Shanin Roman <[email protected]>
Signed-off-by: Shanin Roman <[email protected]>
Signed-off-by: Shanin Roman <[email protected]>
Signed-off-by: Shanin Roman <[email protected]>
DCNick3
approved these changes
Jul 2, 2024
0x009922
approved these changes
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Migrate from
warptoaxum.With current implementation i tried to preserve the same behavior as before.
I would suggest further improvements in the separate PRs.
Linked issue
Closes #3776
Benefits
Bring more simplicity to torii.