Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor!: remove _id suffix for entity ids in public API #4714

Merged
merged 1 commit into from
Jun 11, 2024
Merged

refactor!: remove _id suffix for entity ids in public API #4714

merged 1 commit into from
Jun 11, 2024

Conversation

mversic
Copy link
Contributor

@mversic mversic commented Jun 10, 2024 •
edited
Loading

Description

Remove _id suffix from tokens, config files and data model

Linked issue

Closes #{issue_number}

Benefits

Checklist

  • I've read CONTRIBUTING.md
  • I've used the standard signed-off commit format (or will squash just before merging)
  • All applicable CI checks pass (or I promised to make them pass later)
  • (optional) I've written unit tests for the code changes
  • I replied to all comments after code review, marking all implemented changes with thumbs up

@mversic mversic self-assigned this Jun 10, 2024
@github-actions github-actions bot added api-changes Changes in the API for client libraries config-changes Changes in configuration and start up of the Iroha labels Jun 10, 2024
@github-actions GitHub Actions
Copy link

@BAStos525

@mversic mversic force-pushed the shorten_ids branch 4 times, most recently from 113bc59 to 2cd7b61 Compare June 10, 2024 18:43
0x009922
0x009922 approved these changes Jun 11, 2024
View reviewed changes
scripts/test_env.py Show resolved Hide resolved
smart_contract/executor/src/default.rs Show resolved Hide resolved
@mversic mversic merged commit 660de17 into hyperledger-iroha:main Jun 11, 2024
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0x009922 0x009922 0x009922 approved these changes

@nxsaken nxsaken nxsaken approved these changes

@s8sato s8sato Awaiting requested review from s8sato s8sato is a code owner

@SamHSmith SamHSmith Awaiting requested review from SamHSmith

@outoftardis outoftardis Awaiting requested review from outoftardis outoftardis is a code owner

@Erigara Erigara Awaiting requested review from Erigara

@DCNick3 DCNick3 Awaiting requested review from DCNick3 DCNick3 is a code owner

@VAmuzing VAmuzing Awaiting requested review from VAmuzing

@dima74 dima74 Awaiting requested review from dima74 dima74 is a code owner

Assignees

@DCNick3 DCNick3

@0x009922 0x009922

@mversic mversic

Labels
api-changes Changes in the API for client libraries config-changes Changes in configuration and start up of the Iroha
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mversic @nxsaken @0x009922 @DCNick3