feat: Add detect support for parity_scale_decoder
#4680
Merged
+62
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aplio
requested review from
s8sato,
mversic,
SamHSmith,
outoftardis,
Erigara,
0x009922,
DCNick3,
VAmuzing and
dima74
as code owners
aplio
force-pushed
the
feat/add-detect-color-support-for-parity_scale_cli
branch
from
87f50ac to
a821d8c
Compare
aplio
changed the title
parity_scale_decoderparity_scale_decoder
aplio
changed the title
parity_scale_decoderparity_scale_decoder
nxsaken
reviewed
Jun 4, 2024
nxsaken
approved these changes
Jun 4, 2024
nxsaken
force-pushed
the
feat/add-detect-color-support-for-parity_scale_cli
branch
from
9c55d82 to
7d8a830
Compare
0x009922
approved these changes
Jun 6, 2024
Signed-off-by: aplio <[email protected]>
Signed-off-by: aplio <[email protected]>
Signed-off-by: aplio <[email protected]>
nxsaken
force-pushed
the
feat/add-detect-color-support-for-parity_scale_cli
branch
from
7d8a830 to
5f9eb90
Compare
|
@nxsaken looks like clear to merge |
|
Thank you @aplio! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Linked issue
Closes #4487
Benefits
Users don't have to rebuild
parity_scale_cliwhen disabling terminal-colors.Which seems not happening right now since no color is used in parity_scale_cli for now.
Checklist
CONTRIBUTING.md