Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor!: rename iroha server and client #4662

Merged
merged 4 commits into from
May 29, 2024
Merged

refactor!: rename iroha server and client #4662

merged 4 commits into from
May 29, 2024

Conversation

mversic
Copy link
Contributor

@mversic mversic commented May 28, 2024 •
edited by nxsaken
Loading

Description

  • rename iroha crate and binary to irohad
  • rename iroha_client_cli binary to iroha
  • rename iroha_client crate and binary to iroha
  • rename iroha_wasm_builder_cli binary to iroha_wasm_builder

Linked issue

Closes #4512

Benefits

Checklist

  • I've read CONTRIBUTING.md
  • I've used the standard signed-off commit format (or will squash just before merging)
  • All applicable CI checks pass (or I promised to make them pass later)
  • (optional) I've written unit tests for the code changes
  • I replied to all comments after code review, marking all implemented changes with thumbs up

@github-actions github-actions bot added the api-changes Changes in the API for client libraries label May 28, 2024
@mversic mversic force-pushed the rename_iroha branch 3 times, most recently from b6cfea1 to f951afc Compare May 28, 2024 15:54
nxsaken
nxsaken previously approved these changes May 29, 2024
View reviewed changes
@mversic mversic requested a review from nxsaken May 29, 2024 09:59
DCNick3
DCNick3 reviewed May 29, 2024
View reviewed changes
Copy link
Contributor

@DCNick3 DCNick3 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given more developers will interact with iroha client cli than with the node itself, naming it iroha does make sense. I hope this doesn't lead to confusion down the line.

tools/wasm_builder_cli/README.md Outdated Show resolved Hide resolved
@mversic mversic enabled auto-merge (squash) May 29, 2024 10:30
@mversic mversic requested a review from DCNick3 May 29, 2024 10:30
@mversic mversic merged commit 5085ff2 into hyperledger-iroha:main May 29, 2024
12 of 13 checks passed
@dima74 dima74 mentioned this pull request May 29, 2024
Merged
@mversic mversic deleted the rename_iroha branch June 2, 2024 09:30
@nxsaken nxsaken mentioned this pull request Jul 3, 2024
Closed
@0x009922 0x009922 mentioned this pull request Jul 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nxsaken nxsaken nxsaken approved these changes

@DCNick3 DCNick3 DCNick3 approved these changes

@s8sato s8sato Awaiting requested review from s8sato s8sato is a code owner

@SamHSmith SamHSmith Awaiting requested review from SamHSmith

@outoftardis outoftardis Awaiting requested review from outoftardis outoftardis is a code owner

@Erigara Erigara Awaiting requested review from Erigara

@0x009922 0x009922 Awaiting requested review from 0x009922 0x009922 is a code owner

@VAmuzing VAmuzing Awaiting requested review from VAmuzing

@dima74 dima74 Awaiting requested review from dima74 dima74 is a code owner

Assignees

@DCNick3 DCNick3

@nxsaken nxsaken

@mversic mversic

Labels
api-changes Changes in the API for client libraries
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename iroha_client_cli into iroha
3 participants
@mversic @DCNick3 @nxsaken