Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add get_original_transaction_by_hash #4636

Merged

Conversation

enxtur
Copy link

@enxtur enxtur commented May 22, 2024

Description

Added a method to retrieve a pending partially signed transaction by its transaction hash from the queue. Previously, existing methods required the entire transaction payload, which was cumbersome for other users who needed to build the entire transaction for signing. Now, only the transaction hash is needed.

Benefits

This improvement simplifies the process for users who need to sign transactions, as they no longer need to reconstruct the entire transaction payload. Instead, they can simply use the transaction hash. This change aligns more closely with real-world use cases, making the signing process more practical and efficient.

Checklist

  • I've read CONTRIBUTING.md
  • I've used the standard signed-off commit format (or will squash just before merging)
  • All applicable CI checks pass (or I promised to make them pass later)
  • (optional) I've written unit tests for the code changes
  • I replied to all comments after code review, marking all implemented changes with thumbs up

@mversic
Copy link
Contributor

mversic commented May 22, 2024

can you tell us more on how do you use PENDING_TRANSACTIONS?

@enxtur
Copy link
Author

enxtur commented May 22, 2024

can you tell us more on how do you use PENDING_TRANSACTIONS?

Well, simply for fetching those encoded pending transactions, if I understand correctly.
In my personal experience, I was able to fetch pending transactions using API directly and filtered with hash. So I thought this new method will make life easier.

@mversic
Copy link
Contributor

mversic commented May 22, 2024

can you tell us more on how do you use PENDING_TRANSACTIONS?

Well, simply for fetching those encoded pending transactions, if I understand correctly. In my personal experience, I was able to fetch pending transactions using API directly and filtered with hash. So I thought this new method will make life easier.

ok. But what do you do with pending transactions after you fetch them? I'm just trying to understand your use-case, not related to this PR

@enxtur
Copy link
Author

enxtur commented May 22, 2024

can you tell us more on how do you use PENDING_TRANSACTIONS?

Well, simply for fetching those encoded pending transactions, if I understand correctly. In my personal experience, I was able to fetch pending transactions using API directly and filtered with hash. So I thought this new method will make life easier.

ok. But what do you do with pending transactions after you fetch them? I'm just trying to understand your use-case, not related to this PR

I would like another account to sign it.

@enxtur enxtur force-pushed the get_original_transaction_by_hash branch from fcfa275 to 9c28417 Compare May 24, 2024 15:12
@mversic mversic force-pushed the get_original_transaction_by_hash branch from 9c28417 to 0b7b2c6 Compare June 4, 2024 08:58
@mversic mversic enabled auto-merge (squash) June 4, 2024 13:09
@nxsaken nxsaken disabled auto-merge June 4, 2024 13:12
@nxsaken nxsaken merged commit 92f11c8 into hyperledger-iroha:stable Jun 4, 2024
0 of 4 checks passed
@enxtur enxtur deleted the get_original_transaction_by_hash branch June 4, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants