Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix] #4403: Trigger metadata is accessible in smart contracts (BACKPORT) #4406

Merged
merged 2 commits into from
Apr 4, 2024
Merged

[fix] #4403: Trigger metadata is accessible in smart contracts (BACKPORT) #4406

merged 2 commits into from
Apr 4, 2024

Conversation

Erigara
Copy link
Contributor

@Erigara Erigara commented Apr 3, 2024

Description

  • .metadata() now available in user code
  • CanSetKeyValueInTrigger and CanRemoveKeyValueInTrigger properly handled

Linked issue

Closes #4403

Checklist

  • I've read CONTRIBUTING.md
  • I've used the standard signed-off commit format (or will squash just before merging)
  • All applicable CI checks pass (or I promised to make them pass later)
  • (optional) I've written unit tests for the code changes
  • I replied to all comments after code review, marking all implemented changes with thumbs up

@Erigara Erigara added Bug Something isn't working iroha2-dev The re-implementation of a BFT hyperledger in RUST labels Apr 3, 2024
@Erigara Erigara self-assigned this Apr 3, 2024
@s8sato s8sato self-assigned this Apr 4, 2024
@Erigara Erigara merged commit 742503a into hyperledger-iroha:iroha2-stable Apr 4, 2024
2 of 6 checks passed
@DCNick3 DCNick3 self-assigned this Apr 4, 2024
@timofeevmd timofeevmd self-assigned this Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@s8sato s8sato s8sato approved these changes

@DCNick3 DCNick3 DCNick3 approved these changes

@mversic mversic Awaiting requested review from mversic

@Arjentix Arjentix Awaiting requested review from Arjentix

@SamHSmith SamHSmith Awaiting requested review from SamHSmith

@QuentinI QuentinI Awaiting requested review from QuentinI

@outoftardis outoftardis Awaiting requested review from outoftardis

@ilchu ilchu Awaiting requested review from ilchu

@pesterev pesterev Awaiting requested review from pesterev

@0x009922 0x009922 Awaiting requested review from 0x009922

Assignees

@DCNick3 DCNick3

@Erigara Erigara

@timofeevmd timofeevmd

@s8sato s8sato

Labels
Bug Something isn't working iroha2-dev The re-implementation of a BFT hyperledger in RUST
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Erigara @DCNick3 @s8sato @timofeevmd