Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] #4244: Allow granting/revoking role's permissions #4349

Merged

Conversation

Erigara
Copy link
Contributor

@Erigara Erigara commented Mar 6, 2024

Description

Allow granting/revoking permissions from roles.

Linked issue

Closes #4244

Benefits

Roles are more flexible.

@Erigara Erigara added the iroha2-dev The re-implementation of a BFT hyperledger in RUST label Mar 6, 2024
@Erigara Erigara self-assigned this Mar 6, 2024
@github-actions github-actions bot added Enhancement New feature or request api-changes Changes in the API for client libraries labels Mar 6, 2024
@coveralls
Copy link

coveralls commented Mar 6, 2024

Pull Request Test Coverage Report for Build 8230753938

Details

  • 0 of 57 (0.0%) changed or added relevant lines in 6 files are covered.
  • 3986 unchanged lines in 68 files lost coverage.
  • Overall coverage decreased (-0.07%) to 56.717%

Changes Missing Coverage Covered Lines Changed/Added Lines %
core/src/smartcontracts/isi/world.rs 0 2 0.0%
data_model/src/visit.rs 0 2 0.0%
data_model/src/events/data/events.rs 0 5 0.0%
smart_contract/executor/derive/src/default.rs 0 6 0.0%
data_model/src/isi.rs 0 20 0.0%
smart_contract/executor/src/default.rs 0 22 0.0%
Files with Coverage Reduction New Missed Lines %
tools/kagami/src/crypto.rs 1 12.12%
primitives/src/lib.rs 1 0.0%
core/src/sumeragi/network_topology.rs 1 98.78%
primitives/src/unique_vec.rs 2 91.24%
data_model/src/metadata.rs 2 78.87%
config/src/kura.rs 3 80.0%
config/src/logger.rs 5 72.73%
tools/kagami/src/main.rs 5 0.0%
logger/src/lib.rs 5 94.12%
telemetry/src/dev.rs 7 0.0%
Totals Coverage Status
Change from base Build 7884695009: -0.07%
Covered Lines: 22432
Relevant Lines: 39551

💛 - Coveralls

@Erigara Erigara force-pushed the role_grant_revoke_permissions branch from c0dd13c to e07df2b Compare March 6, 2024 13:30
@s8sato s8sato self-assigned this Mar 7, 2024
s8sato
s8sato previously approved these changes Mar 7, 2024
data_model/src/events/data/events.rs Outdated Show resolved Hide resolved
core/src/smartcontracts/isi/world.rs Show resolved Hide resolved
core/src/smartcontracts/isi/world.rs Show resolved Hide resolved
@Erigara Erigara merged commit 96f8410 into hyperledger-iroha:iroha2-dev Mar 11, 2024
15 checks passed
@timofeevmd timofeevmd added QA-confirmed This bug is reproduced and needs a fix and removed QA-confirmed This bug is reproduced and needs a fix labels Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api-changes Changes in the API for client libraries Enhancement New feature or request iroha2-dev The re-implementation of a BFT hyperledger in RUST
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants