Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[refactor]: remove Value enum #4305

Merged
merged 1 commit into from
Mar 12, 2024

Conversation

mversic
Copy link
Contributor

@mversic mversic commented Feb 20, 2024

Description

  • break dependency of Metadata::Value and Query::Output on Value
  • remove Value enum. It's useless after removal of expressions

Linked issue

Closes #{issue_number}

Benefits

Checklist

  • I've read CONTRIBUTING.md
  • I've used the standard signed-off commit format (or will squash just before merging)
  • All applicable CI checks pass (or I promised to make them pass later)
  • (optional) I've written unit tests for the code changes
  • I replied to all comments after code review, marking all implemented changes with thumbs up

@github-actions github-actions bot added the iroha2-dev The re-implementation of a BFT hyperledger in RUST label Feb 20, 2024
@mversic mversic changed the title [refactor]: introduce MetadataValue and QueryOutputBox [refactor]: remove Value enum Feb 20, 2024
@mversic mversic force-pushed the metadata_value branch 11 times, most recently from 6c6abf3 to 183aed1 Compare February 20, 2024 17:17
@mversic mversic marked this pull request as ready for review February 20, 2024 17:26
@mversic mversic force-pushed the metadata_value branch 2 times, most recently from 36b63e8 to 37584c0 Compare February 26, 2024 07:40
@github-actions github-actions bot added the api-changes Changes in the API for client libraries label Feb 26, 2024
@mversic mversic mentioned this pull request Mar 11, 2024
Erigara
Erigara previously approved these changes Mar 11, 2024
Erigara
Erigara previously approved these changes Mar 11, 2024
s8sato
s8sato previously approved these changes Mar 11, 2024
@mversic mversic dismissed stale reviews from s8sato and Erigara via f984cee March 11, 2024 11:30
@mversic mversic force-pushed the metadata_value branch 4 times, most recently from cdbb840 to 2762318 Compare March 11, 2024 12:28
@mversic mversic enabled auto-merge (squash) March 11, 2024 19:18
@mversic mversic requested a review from Erigara March 11, 2024 19:19
Signed-off-by: Marin Veršić <[email protected]>
@mversic mversic merged commit 702df2d into hyperledger-iroha:iroha2-dev Mar 12, 2024
12 checks passed
@mversic mversic deleted the metadata_value branch March 12, 2024 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api-changes Changes in the API for client libraries iroha2-dev The re-implementation of a BFT hyperledger in RUST
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants