-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[refactor]: remove Value
enum
#4305
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
iroha2-dev
The re-implementation of a BFT hyperledger in RUST
label
Feb 20, 2024
mversic
force-pushed
the
metadata_value
branch
from
February 20, 2024 12:13
fc82743
to
e48f45e
Compare
mversic
changed the title
[refactor]: introduce MetadataValue and QueryOutputBox
[refactor]: remove Feb 20, 2024
Value
enum
mversic
force-pushed
the
metadata_value
branch
11 times, most recently
from
February 20, 2024 17:17
6c6abf3
to
183aed1
Compare
mversic
requested review from
s8sato,
Arjentix,
SamHSmith,
outoftardis,
Erigara,
0x009922,
DCNick3,
VAmuzing,
Asem-Abdelhady and
horizenight
as code owners
February 20, 2024 17:26
mversic
force-pushed
the
metadata_value
branch
2 times, most recently
from
February 26, 2024 07:40
36b63e8
to
37584c0
Compare
Closed
Erigara
reviewed
Mar 11, 2024
Erigara
previously approved these changes
Mar 11, 2024
mversic
force-pushed
the
metadata_value
branch
2 times, most recently
from
March 11, 2024 08:42
b3a8537
to
16b0b4e
Compare
Erigara
previously approved these changes
Mar 11, 2024
s8sato
previously approved these changes
Mar 11, 2024
mversic
force-pushed
the
metadata_value
branch
4 times, most recently
from
March 11, 2024 12:28
cdbb840
to
2762318
Compare
s8sato
approved these changes
Mar 11, 2024
s8sato
approved these changes
Mar 11, 2024
Signed-off-by: Marin Veršić <[email protected]>
Erigara
approved these changes
Mar 12, 2024
This was referenced Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
api-changes
Changes in the API for client libraries
iroha2-dev
The re-implementation of a BFT hyperledger in RUST
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Metadata::Value
andQuery::Output
onValue
Value
enum. It's useless after removal of expressionsLinked issue
Closes #{issue_number}
Benefits
Checklist
CONTRIBUTING.md