Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] #4137: for store tranfer instruction #4258

Conversation

Asem-Abdelhady
Copy link
Contributor

@Asem-Abdelhady Asem-Abdelhady commented Feb 6, 2024

Description

Implementation of the store transfer instruction feature.

Linked issue

Closes #4137

Checklist

  • I've read CONTRIBUTING.md
  • I've used the standard signed-off commit format (or will squash just before merging)
  • All applicable CI checks pass (or I promised to make them pass later)
  • (optional) I've written unit tests for the code changes
  • I replied to all comments after code review, marking all implemented changes with thumbs up

…KS env variable with true

Signed-off-by: Asem-Abdelhady <[email protected]>
…ng PORFILE variable to be test

Signed-off-by: Asem-Abdelhady <[email protected]>
Signed-off-by: Asem Abdelhady <[email protected]>
Signed-off-by: Asem-Abdelhady <[email protected]>
@github-actions github-actions bot added the iroha2-dev The re-implementation of a BFT hyperledger in RUST label Feb 6, 2024
@Arjentix Arjentix self-assigned this Feb 8, 2024
client/tests/integration/transfer_asset.rs Outdated Show resolved Hide resolved
client/tests/integration/transfer_asset.rs Outdated Show resolved Hide resolved
client/tests/integration/transfer_asset.rs Outdated Show resolved Hide resolved
client/tests/integration/transfer_asset.rs Outdated Show resolved Hide resolved
core/src/smartcontracts/isi/asset.rs Outdated Show resolved Hide resolved
core/src/smartcontracts/isi/asset.rs Outdated Show resolved Hide resolved
core/src/smartcontracts/isi/asset.rs Outdated Show resolved Hide resolved
core/src/smartcontracts/isi/asset.rs Show resolved Hide resolved
data_model/src/lib.rs Show resolved Hide resolved
@Asem-Abdelhady Asem-Abdelhady marked this pull request as ready for review February 9, 2024 07:42
@Asem-Abdelhady Asem-Abdelhady force-pushed the store_transfer_feature branch 9 times, most recently from dfcadfb to 027a11e Compare February 11, 2024 22:51
@mversic
Copy link
Contributor

mversic commented Feb 12, 2024

you know, there is git commit --amend

@Asem-Abdelhady Asem-Abdelhady force-pushed the store_transfer_feature branch 5 times, most recently from 9173ef3 to dfcadfb Compare February 12, 2024 07:57
Signed-off-by: Asem-Abdelhady <[email protected]>
@coveralls
Copy link

Pull Request Test Coverage Report for Build 7890703643

Details

  • -25 of 25 (0.0%) changed or added relevant lines in 6 files are covered.
  • 650 unchanged lines in 13 files lost coverage.
  • Overall coverage increased (+0.04%) to 56.829%

Changes Missing Coverage Covered Lines Changed/Added Lines %
core/src/smartcontracts/isi/mod.rs 0 1 0.0%
data_model/src/visit.rs 0 1 0.0%
smart_contract/executor/derive/src/default.rs 0 1 0.0%
core/src/smartcontracts/isi/asset.rs 0 6 0.0%
smart_contract/executor/src/default.rs 0 7 0.0%
data_model/src/isi.rs 0 9 0.0%
Files with Coverage Reduction New Missed Lines %
core/src/query/store.rs 1 73.2%
data_model/src/predicate.rs 9 86.83%
core/src/smartcontracts/isi/tx.rs 13 66.67%
core/src/wsv.rs 17 52.2%
core/src/queue.rs 18 93.52%
core/src/tx.rs 26 53.18%
core/src/kura.rs 31 77.47%
core/src/block.rs 51 85.81%
data_model/src/block.rs 69 34.07%
torii/src/routing.rs 71 0.0%
Totals Coverage Status
Change from base Build 7884695009: 0.04%
Covered Lines: 22798
Relevant Lines: 40117

💛 - Coveralls

@Asem-Abdelhady Asem-Abdelhady merged commit e3a4f42 into hyperledger-iroha:iroha2-dev Feb 13, 2024
13 checks passed
@Asem-Abdelhady Asem-Abdelhady deleted the store_transfer_feature branch February 15, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
iroha2-dev The re-implementation of a BFT hyperledger in RUST
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants