[suggestion] added plain text format#4218 #4236
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nilav Prajapati <[email protected]>
Signed-off-by: Nilav Prajapati <[email protected]>
Signed-off-by: Nilav Prajapati <[email protected]>
Signed-off-by: Nilav Prajapati <[email protected]>
gerceboss
requested review from
s8sato,
mversic,
Arjentix,
SamHSmith,
QuentinI,
outoftardis,
ilchu,
pesterev,
Erigara,
0x009922 and
DCNick3
as code owners
github-actions
bot
added
the
iroha2-dev
DCNick3
reviewed
Jan 24, 2024
torii/src/routing.rs
Outdated
| pub fn handle_health() -> Json { | ||
| reply::json(&Health::Healthy) | ||
| pub fn handle_health() -> impl warp::Reply { | ||
| warp::reply::with_status("Healthy", StatusCode::OK).header("Content-Type", "text/plain") |
There was a problem hiding this comment.
Returning a &'static str will be more terse and will still correctly set the Content-Type header: https://docs.rs/warp/latest/src/warp/reply.rs.html#436-443
torii/src/routing.rs
Outdated
| use iroha_version::Version; | ||
|
|
||
| let string = sumeragi | ||
| .apply_wsv(WorldStateView::latest_block_ref) | ||
| .expect("Genesis not applied. Nothing we can do. Solve the issue and rerun.") | ||
| .version() | ||
| .to_string(); | ||
| reply::json(&string) | ||
| warp::reply::with_status(string, warp::http::StatusCode::OK).header("Content-Type", "text/plain") |
There was a problem hiding this comment.
Same, but can return the version String directly
|
Also, please make sure your PR title and commit messages follow the format we use. This PR also should be a single commit (not four), as it is a small change. |
|
No problem ,I will do that by tomorrow |
|
@gerceboss will you finalize this PR? |
|
@gerceboss please comment :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Linked issue
Closes #4218
Benefits
removes redundancy
Checklist
CONTRIBUTING.md